From: Francois Romieu <romieu@fr.zoreil.com>
To: Daniele Venzano <webvenza@libero.it>
Cc: netdev@oss.sgi.com, jgarzik@pobox.com
Subject: Re: [PATCH 1/1] More ethtool support for sis900 (with locking)
Date: Sat, 5 Mar 2005 22:28:38 +0100 [thread overview]
Message-ID: <20050305212838.GD25116@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20050305210745.6763.6618@localhost.localdomain>
Daniele Venzano <webvenza@libero.it> :
[...]
> Index: sis900.c
> ===================================================================
> --- a/drivers/net/sis900.c (revision 95)
> +++ b/drivers/net/sis900.c (revision 98)
[...]
> @@ -1943,10 +1952,47 @@
> sis_priv->msg_enable = value;
> }
>
> +static u32 sis900_get_link(struct net_device *net_dev)
> +{
> + struct sis900_private *sis_priv = net_dev->priv;
Any reason to not use netdev_priv() ?
I would not mind an empty line between the declaration of variables
and the actual code.
--
Ueimor
next prev parent reply other threads:[~2005-03-05 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 21:07 [PATCH 1/1] More ethtool support for sis900 (with locking) Daniele Venzano
2005-03-05 21:28 ` Francois Romieu [this message]
2005-03-06 10:01 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050305212838.GD25116@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=webvenza@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).