netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 05/26] net/ixgb_ethtool: replace schedule_timeout() with msleep_interruptible()
@ 2005-03-06 10:32 domen
  0 siblings, 0 replies; only message in thread
From: domen @ 2005-03-06 10:32 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev, domen, nacc, janitor





Use msleep_interruptible() instead of 
schedule_timeout() to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/drivers/net/ixgb/ixgb_ethtool.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/net/ixgb/ixgb_ethtool.c~msleep_interruptible-drivers_net_ixgb_ixgb_ethtool drivers/net/ixgb/ixgb_ethtool.c
--- kj/drivers/net/ixgb/ixgb_ethtool.c~msleep_interruptible-drivers_net_ixgb_ixgb_ethtool	2005-03-05 16:09:32.000000000 +0100
+++ kj-domen/drivers/net/ixgb/ixgb_ethtool.c	2005-03-05 16:09:32.000000000 +0100
@@ -617,9 +617,9 @@ ixgb_phys_id(struct net_device *netdev, 
 
 	set_current_state(TASK_INTERRUPTIBLE);
 	if(data)
-		schedule_timeout(data * HZ);
+		msleep_interruptible(data * 1000);
 	else
-		schedule_timeout(MAX_SCHEDULE_TIMEOUT);
+		msleep_interruptible(jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT));
 
 	del_timer_sync(&adapter->blink_timer);
 	ixgb_led_off(&adapter->hw);
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-06 10:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-06 10:32 [patch 05/26] net/ixgb_ethtool: replace schedule_timeout() with msleep_interruptible() domen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).