netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 15/26] net/skethtool: remove duplicate delay
@ 2005-03-06 10:33 domen
  0 siblings, 0 replies; only message in thread
From: domen @ 2005-03-06 10:33 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev, domen, nacc



Please consider applying. 

Remove an unnecessary second (and identical) delay.
schedule_timeout() does not need to be called, as msleep_interruptible() already
delayed the task.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/drivers/net/sk98lin/skethtool.c |    3 ---
 1 files changed, 3 deletions(-)

diff -puN drivers/net/sk98lin/skethtool.c~remove_duplicate_delay-drivers_net_sk98lin_skethtool drivers/net/sk98lin/skethtool.c
--- kj/drivers/net/sk98lin/skethtool.c~remove_duplicate_delay-drivers_net_sk98lin_skethtool	2005-03-05 16:11:09.000000000 +0100
+++ kj-domen/drivers/net/sk98lin/skethtool.c	2005-03-05 16:11:09.000000000 +0100
@@ -437,9 +437,6 @@ static int locateDevice(struct net_devic
 	pAC->LedsOn = 0;
 	mod_timer(&pAC->BlinkTimer, jiffies);
 	msleep_interruptible(data * 1000);
-
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout(data * HZ);
 	del_timer_sync(&pAC->BlinkTimer);
 	toggleLeds(pNet, 0);
 
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-06 10:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-06 10:33 [patch 15/26] net/skethtool: remove duplicate delay domen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).