* [patch 1/2] net/orinoco_plx: replace schedule_timeout() with ssleep()
@ 2005-03-06 22:21 domen
2005-03-07 0:57 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: domen @ 2005-03-06 22:21 UTC (permalink / raw)
To: proski; +Cc: hermes, netdev, domen, nacc, janitor
Use ssleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/wireless/orinoco_plx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/net/wireless/orinoco_plx.c~ssleep-drivers_net_wireless_orinoco_plx drivers/net/wireless/orinoco_plx.c
--- kj/drivers/net/wireless/orinoco_plx.c~ssleep-drivers_net_wireless_orinoco_plx 2005-03-05 16:09:49.000000000 +0100
+++ kj-domen/drivers/net/wireless/orinoco_plx.c 2005-03-05 16:09:49.000000000 +0100
@@ -136,6 +136,7 @@
#include <linux/list.h>
#include <linux/pci.h>
#include <linux/fcntl.h>
+#include <linux/delay.h>
#include <pcmcia/cisreg.h>
@@ -352,8 +353,7 @@ static int __init orinoco_plx_init(void)
static void __exit orinoco_plx_exit(void)
{
pci_unregister_driver(&orinoco_plx_driver);
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout(HZ);
+ ssleep(1);
}
module_init(orinoco_plx_init);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/2] net/orinoco_plx: replace schedule_timeout() with ssleep()
2005-03-06 22:21 [patch 1/2] net/orinoco_plx: replace schedule_timeout() with ssleep() domen
@ 2005-03-07 0:57 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2005-03-07 0:57 UTC (permalink / raw)
To: domen; +Cc: proski, netdev, nacc, janitor
On Sun, Mar 06, 2005 at 11:21:40PM +0100, domen@coderock.org wrote:
>
> Use ssleep() instead of schedule_timeout()
> to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> Signed-off-by: Domen Puncer <domen@coderock.org>
Already in CVS, patch already sent to Jeff. Likewise for orinoco_tmd.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist. NOT _the_ _other_ _way_
| _around_!
http://www.ozlabs.org/people/dgibson
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-07 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-06 22:21 [patch 1/2] net/orinoco_plx: replace schedule_timeout() with ssleep() domen
2005-03-07 0:57 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).