* [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()
@ 2005-03-06 22:23 domen
2005-03-07 17:13 ` Luis R. Rodriguez
0 siblings, 1 reply; 2+ messages in thread
From: domen @ 2005-03-06 22:23 UTC (permalink / raw)
To: prism54-private; +Cc: netdev, domen, nacc, janitor
Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected. Also set_current_state() is
inserted before schedule_timeout().
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/wireless/prism54/islpci_dev.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c
--- kj/drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev 2005-03-05 16:09:30.000000000 +0100
+++ kj-domen/drivers/net/wireless/prism54/islpci_dev.c 2005-03-05 16:09:30.000000000 +0100
@@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
wmb();
/* wait a while for the device to reset */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(50*HZ/1000);
+ msleep(50);
return 0;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()
2005-03-06 22:23 [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep() domen
@ 2005-03-07 17:13 ` Luis R. Rodriguez
0 siblings, 0 replies; 2+ messages in thread
From: Luis R. Rodriguez @ 2005-03-07 17:13 UTC (permalink / raw)
To: domen; +Cc: prism54-private, netdev, nacc, janitor
[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]
Patch applied to prism54 latest svn tree, thanks
Luis
On Sun, Mar 06, 2005 at 11:23:51PM +0100, domen@coderock.org wrote:
>
>
>
>
> Use msleep() instead of schedule_timeout()
> to guarantee the task delays as expected. Also set_current_state() is
> inserted before schedule_timeout().
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/drivers/net/wireless/prism54/islpci_dev.c | 3 +--
> 1 files changed, 1 insertion(+), 2 deletions(-)
>
> diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c
> --- kj/drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev 2005-03-05 16:09:30.000000000 +0100
> +++ kj-domen/drivers/net/wireless/prism54/islpci_dev.c 2005-03-05 16:09:30.000000000 +0100
> @@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
> wmb();
>
> /* wait a while for the device to reset */
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(50*HZ/1000);
> + msleep(50);
>
> return 0;
> }
> _
--
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-07 17:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-06 22:23 [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep() domen
2005-03-07 17:13 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).