From: Thomas Graf <tgraf@suug.ch>
To: Andi Kleen <ak@muc.de>
Cc: "David S. Miller" <davem@davemloft.net>,
baruch@ev-en.org, shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: netif_rx packet dumping
Date: Tue, 8 Mar 2005 19:37:59 +0100 [thread overview]
Message-ID: <20050308183759.GE31837@postel.suug.ch> (raw)
In-Reply-To: <20050308181844.GA37392@muc.de>
* Andi Kleen <20050308181844.GA37392@muc.de> 2005-03-08 19:18
> There are some other savings possible e.g. from a quick look:
> - skb->list is afaik totally unnecessary and probably even unused.
> - struct timeval could be an optimized structure using 32bit
> for the sub second part.
> (would need moving it somewhere else, otherwise alignment doesn't help)
> - Are really three device pointers needed? Perhaps things can
> be a bit optimized here.
Likely that real_dev can be moved to cb. I would like to keep indev
though, it really helps at policy routing decisions.
> - Hippi could be finally changed to use skb->cb instead of its
> private field.
Definitely.
> - is skb->security still needed? It should be obsolete with ->sec_path, no?
> Would only help together with the timestamp optimization.
security has been unused for quite some time as far as I can see.
Anyone going for a patch? Otherwise I'll give it a try.
Speaking of it, I see tcp_sock is marginal over 2**10 on 32 bit archs and
Stephen's plans to outsource the cc bits brings us closer to the border.
Would it be worth to try and get it below 2**10? I spotted some places
for optimizations but not enough to really save the needed amount.
next prev parent reply other threads:[~2005-03-08 18:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 20:38 netif_rx packet dumping Stephen Hemminger
2005-03-03 20:55 ` David S. Miller
2005-03-03 21:01 ` Stephen Hemminger
2005-03-03 21:18 ` jamal
2005-03-03 21:21 ` Stephen Hemminger
2005-03-03 21:24 ` jamal
2005-03-03 21:32 ` David S. Miller
2005-03-03 21:54 ` Stephen Hemminger
2005-03-03 22:02 ` John Heffner
2005-03-03 22:26 ` jamal
2005-03-03 23:16 ` Stephen Hemminger
2005-03-03 23:40 ` jamal
2005-03-03 23:48 ` Baruch Even
2005-03-04 3:45 ` jamal
2005-03-04 8:47 ` Baruch Even
2005-03-07 13:55 ` jamal
2005-03-08 15:56 ` Baruch Even
2005-03-08 22:02 ` jamal
2005-03-22 21:55 ` cliff white
2005-03-03 23:48 ` John Heffner
2005-03-04 1:42 ` Lennert Buytenhek
2005-03-04 3:10 ` John Heffner
2005-03-04 3:31 ` Lennert Buytenhek
2005-03-04 19:52 ` Edgar E Iglesias
2005-03-04 19:54 ` Stephen Hemminger
2005-03-04 21:41 ` Edgar E Iglesias
2005-03-04 19:49 ` Jason Lunz
2005-03-03 22:01 ` jamal
2005-03-03 21:26 ` Baruch Even
2005-03-03 21:36 ` David S. Miller
2005-03-03 21:44 ` Baruch Even
2005-03-03 21:54 ` Andi Kleen
2005-03-03 22:04 ` David S. Miller
2005-03-03 21:57 ` David S. Miller
2005-03-03 22:14 ` Baruch Even
2005-03-08 15:42 ` Baruch Even
2005-03-08 17:00 ` Andi Kleen
2005-03-08 18:01 ` Baruch Even
2005-03-08 18:09 ` David S. Miller
2005-03-08 18:18 ` Andi Kleen
2005-03-08 18:37 ` Thomas Graf [this message]
2005-03-08 18:51 ` Arnaldo Carvalho de Melo
2005-03-08 22:16 ` Andi Kleen
2005-03-08 18:27 ` Ben Greear
2005-03-09 23:57 ` Thomas Graf
2005-03-10 0:03 ` Stephen Hemminger
2005-03-10 8:33 ` Andi Kleen
2005-03-10 14:08 ` Thomas Graf
2005-03-31 16:33 ` Baruch Even
2005-03-03 22:03 ` jamal
2005-03-03 22:31 ` Baruch Even
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308183759.GE31837@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=ak@muc.de \
--cc=baruch@ev-en.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).