netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@us.ibm.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 5/5] r8169: ethtool hardware statistics support
Date: Wed, 9 Mar 2005 22:21:48 -0600	[thread overview]
Message-ID: <200503092221.48487.jdmason@us.ibm.com> (raw)
In-Reply-To: <20050309135345.5efae9b6@dxpl.pdx.osdl.net>

On Wednesday 09 March 2005 03:53 pm, Stephen Hemminger wrote:
> On Wed, 9 Mar 2005 15:37:30 -0600
>
> Jon Mason <jdmason@us.ibm.com> wrote:
> > Does this patch fix the problem of bogus statistics if the interface is
> > down
>
> I see no problem when interface is down. It returns all zero's because
> the device is reset on probe (and on shutdown).

I can confirm that I see no statistic errors either. 

I believe the faulty code in Richard's patch was:
+       if (RTL_R32(StatsAddrLow) & DumpStats)
+               return; /* no stats - took too long */

Which returned before the stats were populated (leaving garbage).  Since your 
patch lacks this, we see no problem.  If this is true, there is probably a 
problem on 8139cp, which has a similar error path in its cp_get_ethtool_stats 
function.   

Thanks,
Jon

  reply	other threads:[~2005-03-10  4:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-09 19:36 [PATCH 5/5] r8169: ethtool hardware statistics support Stephen Hemminger
2005-03-09 19:53 ` Jeff Garzik
2005-03-09 21:37 ` Jon Mason
2005-03-09 21:53   ` Stephen Hemminger
2005-03-10  4:21     ` Jon Mason [this message]
2005-03-10 20:00       ` Stephen Hemminger
2005-03-10 20:09         ` Jeff Garzik
2005-03-12 12:32 ` Richard Dawe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503092221.48487.jdmason@us.ibm.com \
    --to=jdmason@us.ibm.com \
    --cc=netdev@oss.sgi.com \
    --cc=romieu@fr.zoreil.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).