* [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message
@ 2005-03-15 0:14 Thomas Graf
2005-03-15 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-15 5:21 ` David S. Miller
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Graf @ 2005-03-15 0:14 UTC (permalink / raw)
To: David S. Miller; +Cc: YOSHIFUJI Hideaki, netdev
Use dev_get_flags() in inet6_fill_ifinfo() to fetch interface flags
to ensure correctly reporting IFF_PROMISC and IFF_ALLMULTI flags.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
--- linux-2.6.11-bk10.orig/net/ipv6/addrconf.c 2005-03-14 19:40:28.000000000 +0100
+++ linux-2.6.11-bk10/net/ipv6/addrconf.c 2005-03-14 21:08:28.000000000 +0100
@@ -2923,12 +2923,8 @@
r->ifi_family = AF_INET6;
r->ifi_type = dev->type;
r->ifi_index = dev->ifindex;
- r->ifi_flags = dev->flags;
+ r->ifi_flags = dev_get_flags(dev);
r->ifi_change = 0;
- if (!netif_running(dev) || !netif_carrier_ok(dev))
- r->ifi_flags &= ~IFF_RUNNING;
- else
- r->ifi_flags |= IFF_RUNNING;
RTA_PUT(skb, IFLA_IFNAME, strlen(dev->name)+1, dev->name);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message
2005-03-15 0:14 [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message Thomas Graf
@ 2005-03-15 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-15 5:21 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-03-15 0:26 UTC (permalink / raw)
To: tgraf, davem; +Cc: netdev
In article <20050315001417.GB3086@postel.suug.ch> (at Tue, 15 Mar 2005 01:14:17 +0100), Thomas Graf <tgraf@suug.ch> says:
> Use dev_get_flags() in inet6_fill_ifinfo() to fetch interface flags
> to ensure correctly reporting IFF_PROMISC and IFF_ALLMULTI flags.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
sane to me.
--yoshfuji
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message
2005-03-15 0:14 [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message Thomas Graf
2005-03-15 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2005-03-15 5:21 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2005-03-15 5:21 UTC (permalink / raw)
To: Thomas Graf; +Cc: yoshfuji, netdev
On Tue, 15 Mar 2005 01:14:17 +0100
Thomas Graf <tgraf@suug.ch> wrote:
> Use dev_get_flags() in inet6_fill_ifinfo() to fetch interface flags
> to ensure correctly reporting IFF_PROMISC and IFF_ALLMULTI flags.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks Thomas.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-15 5:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 0:14 [PATCH] [IPV6] Use dev_get_flags() while building inet6 ifinfo message Thomas Graf
2005-03-15 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-15 5:21 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).