From: Chuck Ebbert <76306.1226@compuserve.com>
To: linux-netdev <netdev@oss.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, Christoph Lameter <clameter@sgi.com>
Subject: [PATCH] Optimize loopback stats
Date: Tue, 15 Mar 2005 14:56:15 -0500 [thread overview]
Message-ID: <200503151459_MC3-1-989A-61A4@compuserve.com> (raw)
This patch optimizes the loopback driver's statistics by using a single
counter for rx and tx stats instead of one for rx and one for tx. It also
adds unlikely() to the test for TSO since it's no longer supported by default.
(Maybe the TSO code should be bracketed by "#if 0" ?)
o saves 84 bytes per CPU on 32bit and 168 bytes on 64 bit
(should save 84K data on 512-way ia64)
o AFAICT the driver is ~2.5% faster sending PF_PACKET data
o applies on top of Christoph's patch in -mm that removes update
of the device's last_rx field
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
--- 2.6.11-mm/drivers/net/loopback.c 2005-03-15 14:23:30.180677000 -0500
+++ 2.6.11-ce/drivers/net/loopback.c 2005-03-15 14:26:23.700677000 -0500
@@ -58,7 +58,12 @@
#include <linux/tcp.h>
#include <linux/percpu.h>
-static DEFINE_PER_CPU(struct net_device_stats, loopback_stats);
+struct loopback_device_stats {
+ unsigned long rx_tx_bytes;
+ unsigned long rx_tx_packets;
+};
+
+static DEFINE_PER_CPU(struct loopback_device_stats, loopback_stats);
#define LOOPBACK_OVERHEAD (128 + MAX_HEADER + 16 + 16)
@@ -126,7 +131,7 @@ static void emulate_large_send_offload(s
*/
static int loopback_xmit(struct sk_buff *skb, struct net_device *dev)
{
- struct net_device_stats *lb_stats;
+ struct loopback_device_stats *lb_stats;
skb_orphan(skb);
@@ -136,7 +141,7 @@ static int loopback_xmit(struct sk_buff
skb->ip_summed = CHECKSUM_UNNECESSARY;
#endif
- if (skb_shinfo(skb)->tso_size) {
+ if (unlikely(skb_shinfo(skb)->tso_size)) {
BUG_ON(skb->protocol != htons(ETH_P_IP));
BUG_ON(skb->nh.iph->protocol != IPPROTO_TCP);
@@ -145,10 +150,8 @@ static int loopback_xmit(struct sk_buff
}
lb_stats = &per_cpu(loopback_stats, get_cpu());
- lb_stats->rx_bytes += skb->len;
- lb_stats->tx_bytes += skb->len;
- lb_stats->rx_packets++;
- lb_stats->tx_packets++;
+ lb_stats->rx_tx_bytes += skb->len;
+ lb_stats->rx_tx_packets++;
put_cpu();
netif_rx(skb);
@@ -168,15 +171,15 @@ static struct net_device_stats *get_stat
memset(stats, 0, sizeof(struct net_device_stats));
for (i=0; i < NR_CPUS; i++) {
- struct net_device_stats *lb_stats;
+ struct loopback_device_stats *lb_stats;
if (!cpu_possible(i))
continue;
lb_stats = &per_cpu(loopback_stats, i);
- stats->rx_bytes += lb_stats->rx_bytes;
- stats->tx_bytes += lb_stats->tx_bytes;
- stats->rx_packets += lb_stats->rx_packets;
- stats->tx_packets += lb_stats->tx_packets;
+ stats->rx_bytes += lb_stats->rx_tx_bytes;
+ stats->tx_bytes = stats->rx_bytes;
+ stats->rx_packets += lb_stats->rx_tx_packets;
+ stats->tx_packets = stats->rx_packets;
}
return stats;
_
--
Chuck
next reply other threads:[~2005-03-15 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 19:56 Chuck Ebbert [this message]
2005-03-15 20:14 ` [PATCH] Optimize loopback stats Nivedita Singhvi
2005-03-15 20:49 ` Nivedita Singhvi
-- strict thread matches above, loose matches on Subject: below --
2005-03-15 23:15 Chuck Ebbert
2005-03-16 0:09 ` Nivedita Singhvi
2005-03-16 0:18 ` Nivedita Singhvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503151459_MC3-1-989A-61A4@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).