From: "David S. Miller" <davem@davemloft.net>
To: Andrew Morton <akpm@osdl.org>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, christoph@graphe.net,
nirajk@calsoftinc.com, christoph@lameter.com, Shai@Scalex86.org
Subject: Re: [patch 05/13] remove last_rx update from loopback device
Date: Tue, 15 Mar 2005 16:53:45 -0800 [thread overview]
Message-ID: <20050315165345.735573de.davem@davemloft.net> (raw)
In-Reply-To: <20050315150809.579c5e85.akpm@osdl.org>
On Tue, 15 Mar 2005 15:08:09 -0800
Andrew Morton <akpm@osdl.org> wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> > > - dev->last_rx = jiffies;
> > > -
> > > lb_stats = &per_cpu(loopback_stats, get_cpu());
> > > lb_stats->rx_bytes += skb->len;
> > > lb_stats->tx_bytes += skb->len;
> >
> > I disagree. loopback.c is doing precisely what it should be doing.
>
> Nothing actually seems to use last_rx?
For one thing bonding load balancing uses it.
You can argue that bonding of loopback devices is silly.
But there are other things one might be able to do with
last_rx and the fact that every driver faithfully sets
it means that it's a reliable metric to use without
special cases.
These loopback driver SMP optimizations are starting to really
driver me crazy.
next prev parent reply other threads:[~2005-03-16 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 22:22 [patch 05/13] remove last_rx update from loopback device akpm
2005-03-15 22:41 ` Jeff Garzik
2005-03-15 23:08 ` Andrew Morton
2005-03-16 0:53 ` David S. Miller [this message]
2005-03-16 1:04 ` Rick Jones
2005-03-16 1:17 ` David S. Miller
2005-03-16 1:23 ` Nivedita Singhvi
2005-03-16 1:49 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315165345.735573de.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Shai@Scalex86.org \
--cc=akpm@osdl.org \
--cc=christoph@graphe.net \
--cc=christoph@lameter.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=nirajk@calsoftinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).