From: "David S. Miller" <davem@davemloft.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: bunk@stusta.de, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static
Date: Wed, 16 Mar 2005 14:54:48 -0800 [thread overview]
Message-ID: <20050316145448.5a45dddc.davem@davemloft.net> (raw)
In-Reply-To: <20050316145343.6e31ba6a.davem@davemloft.net>
On Wed, 16 Mar 2005 14:53:43 -0800
"David S. Miller" <davem@davemloft.net> wrote:
> On Tue, 15 Mar 2005 15:44:08 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > This patch makes a needlessly global struct static.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> You need to also kill the externs in net/inetpeer.h
>
> Please fix this up and resubmit.
Actually, Adrian, net/inetpeer.h makes use of
inet_peer_unused_tailp in inline functions.
How did you get a successful build after marking
it static?
next prev parent reply other threads:[~2005-03-16 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 14:44 [2.6 patch] net/ipv4/inetpeer.c: make a struct static Adrian Bunk
2005-03-16 22:53 ` David S. Miller
2005-03-16 22:54 ` David S. Miller [this message]
2005-03-17 1:08 ` Adrian Bunk
2005-03-17 4:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050316145448.5a45dddc.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).