From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static Date: Wed, 16 Mar 2005 14:54:48 -0800 Message-ID: <20050316145448.5a45dddc.davem@davemloft.net> References: <20050315144408.GL3189@stusta.de> <20050316145343.6e31ba6a.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: bunk@stusta.de, netdev@oss.sgi.com, linux-kernel@vger.kernel.org To: "David S. Miller" In-Reply-To: <20050316145343.6e31ba6a.davem@davemloft.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Wed, 16 Mar 2005 14:53:43 -0800 "David S. Miller" wrote: > On Tue, 15 Mar 2005 15:44:08 +0100 > Adrian Bunk wrote: > > > This patch makes a needlessly global struct static. > > > > Signed-off-by: Adrian Bunk > > You need to also kill the externs in net/inetpeer.h > > Please fix this up and resubmit. Actually, Adrian, net/inetpeer.h makes use of inet_peer_unused_tailp in inline functions. How did you get a successful build after marking it static?