From: "David S. Miller" <davem@davemloft.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: baruch@ev-en.org, netdev@oss.sgi.com
Subject: Re: [RFC] TCP congestion schedulers
Date: Thu, 17 Mar 2005 20:12:31 -0800 [thread overview]
Message-ID: <20050317201231.6d575e0b.davem@davemloft.net> (raw)
In-Reply-To: <20050314151726.532af90d@dxpl.pdx.osdl.net>
On Mon, 14 Mar 2005 15:17:26 -0800
Stephen Hemminger <shemminger@osdl.org> wrote:
> +/* Hook for advanced congestion control */
> + struct tcp_ca_type *ca_proto;
> +#define TCP_CA_PRIV_SIZE 48
> + u8 *ca_priv[TCP_CA_PRIV_SIZE];
An array of 48 pointers to "u8" eh? :-)
It happens to work, but you're using too much
space (specifically: 48 * sizeof(u8 *)) as a side effect.
Otherwise, the only comment I have is that we lose the tcp_diag
info. Maybe create a "tcpdiag_put" method in there so we can
retain that.
I'm also not so religious anymore about retaining the existing
sysctl functionality to enable/disable ca algs.
next prev parent reply other threads:[~2005-03-18 4:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 21:30 [PATCH] select congestion control with one sysctl Baruch Even
2005-02-23 21:57 ` David S. Miller
2005-02-24 0:23 ` Stephen Hemminger
2005-02-24 0:33 ` David S. Miller
2005-02-26 9:41 ` Arnaldo Carvalho de Melo
[not found] ` <421D30FA.1060900@ev-en.org>
[not found] ` <20050225120814.5fa77b13@dxpl.pdx.osdl.net>
[not found] ` <20050309210442.3e9786a6.davem@davemloft.net>
[not found] ` <4230288F.1030202@ev-en.org>
[not found] ` <20050310182629.1eab09ec.davem@davemloft.net>
[not found] ` <20050311120054.4bbf675a@dxpl.pdx.osdl.net>
[not found] ` <20050311201011.360c00da.davem@davemloft.net>
2005-03-14 23:17 ` [RFC] TCP congestion schedulers Stephen Hemminger
2005-03-15 19:54 ` John Heffner
2005-03-15 22:16 ` John Heffner
2005-03-18 4:12 ` David S. Miller [this message]
2005-03-18 12:53 ` Arnaldo Carvalho de Melo
2005-03-18 13:43 ` jamal
2005-03-18 16:13 ` Arnaldo Carvalho de Melo
2005-03-18 16:45 ` Stephen Hemminger
2005-03-18 16:59 ` Arnaldo Carvalho de Melo
2005-03-19 20:19 ` Andi Kleen
2005-03-21 21:25 ` John Heffner
2005-03-21 21:51 ` David S. Miller
2005-03-21 22:30 ` Baruch Even
2005-03-22 0:10 ` Rick Jones
2005-03-22 1:41 ` Olaf Kirch
2005-03-22 7:41 ` Andi Kleen
2005-03-28 23:51 ` Stephen Hemminger
2005-03-29 15:25 ` Andi Kleen
2005-03-29 17:17 ` Stephen Hemminger
2005-03-29 18:58 ` Rick Jones
2005-03-30 9:41 ` Matt Mackall
2005-03-29 19:32 ` John Heffner
2005-03-29 20:03 ` David S. Miller
2005-03-29 20:09 ` Rick Jones
2005-04-08 19:33 ` John Heffner
2005-04-08 20:20 ` Rick Jones
2005-02-24 1:05 ` [PATCH] select congestion control with one sysctl Daniele Lacamera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050317201231.6d575e0b.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baruch@ev-en.org \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).