From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: davem@davemloft.net, Marcel Holtmann <marcel@holtmann.org>
Cc: netdev@oss.sgi.com
Subject: [PATCH][BLUETOOTH] remove now unneeded references to sk_protinfo
Date: Sat, 19 Mar 2005 15:06:03 -0300 [thread overview]
Message-ID: <20050319180603.GB29585@conectiva.com.br> (raw)
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
Hi David, Marcel,
Please apply this patch, now only the HAM radio protocols
and af_wanpipe uses sk_protinfo.
Available at:
bk://kernel.bkbits.net/acme/connection_sock-2.6
- Arnaldo
[-- Attachment #2: bluetooth_sk_protinfo_removal.patch --]
[-- Type: text/plain, Size: 1795 bytes --]
===================================================================
ChangeSet@1.2289, 2005-03-19 14:41:18-03:00, acme@toy.ghostprotocols.net
[BLUETOOTH] remove now unneeded references to sk_protinfo
Now that sk_protinfo is not used anymore for storing private proto
state, we can safely remove the code in the sock destruct path to
kfree it.
Signed-off-by: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
l2cap.c | 3 ---
rfcomm/sock.c | 3 ---
sco.c | 3 ---
3 files changed, 9 deletions(-)
diff -Nru a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
--- a/net/bluetooth/l2cap.c 2005-03-19 15:01:55 -03:00
+++ b/net/bluetooth/l2cap.c 2005-03-19 15:01:55 -03:00
@@ -264,9 +264,6 @@
skb_queue_purge(&sk->sk_receive_queue);
skb_queue_purge(&sk->sk_write_queue);
-
- if (sk->sk_protinfo)
- kfree(sk->sk_protinfo);
}
static void l2cap_sock_cleanup_listen(struct sock *parent)
diff -Nru a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
--- a/net/bluetooth/rfcomm/sock.c 2005-03-19 15:01:55 -03:00
+++ b/net/bluetooth/rfcomm/sock.c 2005-03-19 15:01:55 -03:00
@@ -196,9 +196,6 @@
rfcomm_dlc_unlock(d);
rfcomm_dlc_put(d);
-
- if (sk->sk_protinfo)
- kfree(sk->sk_protinfo);
}
static void rfcomm_sock_cleanup_listen(struct sock *parent)
diff -Nru a/net/bluetooth/sco.c b/net/bluetooth/sco.c
--- a/net/bluetooth/sco.c 2005-03-19 15:01:55 -03:00
+++ b/net/bluetooth/sco.c 2005-03-19 15:01:55 -03:00
@@ -334,9 +334,6 @@
skb_queue_purge(&sk->sk_receive_queue);
skb_queue_purge(&sk->sk_write_queue);
-
- if (sk->sk_protinfo)
- kfree(sk->sk_protinfo);
}
static void sco_sock_cleanup_listen(struct sock *parent)
next reply other threads:[~2005-03-19 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 18:06 Arnaldo Carvalho de Melo [this message]
2005-03-19 18:28 ` [PATCH][BLUETOOTH] remove now unneeded references to sk_protinfo Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319180603.GB29585@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@davemloft.net \
--cc=marcel@holtmann.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).