* swapped memset arguments.
@ 2005-03-22 2:44 Dave Jones
2005-03-23 4:09 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2005-03-22 2:44 UTC (permalink / raw)
To: netdev
You wouldn't believe how many instances of this bug I've
seen in the last few days in both userspace and kernelspace.
Signed-off-by: Dave Jones <davej@redhat.com>
--- bk-linus/net/ipv4/multipath_wrandom.c~ 2005-03-21 21:40:15.535597104 -0500
+++ bk-linus/net/ipv4/multipath_wrandom.c 2005-03-21 21:40:41.406664104 -0500
@@ -248,7 +248,7 @@ static void wrandom_set_nhinfo(__u32 net
target_route->gw = nh->nh_gw;
target_route->oif = nh->nh_oif;
- memset(&target_route->rcu, sizeof(struct rcu_head), 0);
+ memset(&target_route->rcu, 0, sizeof(struct rcu_head));
INIT_LIST_HEAD(&target_route->dests);
list_add_rcu(&target_route->list, &state[state_idx].head);
@@ -271,7 +271,7 @@ static void wrandom_set_nhinfo(__u32 net
target_dest->network = network;
target_dest->netmask = netmask;
target_dest->prefixlen = prefixlen;
- memset(&target_dest->rcu, sizeof(struct rcu_head), 0);
+ memset(&target_dest->rcu, 0, sizeof(struct rcu_head));
list_add_rcu(&target_dest->list, &target_route->dests);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: swapped memset arguments.
2005-03-22 2:44 swapped memset arguments Dave Jones
@ 2005-03-23 4:09 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-03-23 4:09 UTC (permalink / raw)
To: Dave Jones; +Cc: netdev
On Mon, 21 Mar 2005 21:44:57 -0500
Dave Jones <davej@redhat.com> wrote:
> You wouldn't believe how many instances of this bug I've
> seen in the last few days in both userspace and kernelspace.
Hehe.
> Signed-off-by: Dave Jones <davej@redhat.com>
Applied, thanks Dave.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-23 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-22 2:44 swapped memset arguments Dave Jones
2005-03-23 4:09 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).