From: "David S. Miller" <davem@davemloft.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: mchan@broadcom.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.11 4/8] tg3: Add msi test
Date: Tue, 22 Mar 2005 14:17:14 -0800 [thread overview]
Message-ID: <20050322141714.4515258f.davem@davemloft.net> (raw)
In-Reply-To: <424098E2.6090007@pobox.com>
On Tue, 22 Mar 2005 17:14:58 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:
> OK, so this is not a tg3-related problem at all.
Right.
> It really sounds like you should update pci_msi_quirk() to cover the
> other affected cases.
That's not possible without either:
1) getting a lot of chipset vendors to reveal stuff they probably
would rather keep secret (ie. that their chip in particular has
MSI problems)
2) having a device on which to perform the MSI usability check
See #2? That's the main issue from genericizing this, we need
a device on which to perform the usability check so that we can
handling a test interrupt and see if state got updated correctly.
So for the time being, Michael's change is OK until we find a
better solution that really does cover all the problem chipsets.
next prev parent reply other threads:[~2005-03-22 22:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 22:07 [PATCH 2.6.11 4/8] tg3: Add msi test Michael Chan
2005-03-22 22:14 ` Jeff Garzik
2005-03-22 22:17 ` David S. Miller [this message]
2005-03-22 22:26 ` Jeff Garzik
2005-03-22 23:40 ` David S. Miller
2005-03-22 23:50 ` Jeff Garzik
2005-03-22 23:52 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-03-23 18:16 Michael Chan
2005-03-21 7:43 Michael Chan
2005-03-22 20:57 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050322141714.4515258f.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).