From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH 2.6.11 4/8] tg3: Add msi test Date: Tue, 22 Mar 2005 14:17:14 -0800 Message-ID: <20050322141714.4515258f.davem@davemloft.net> References: <424098E2.6090007@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: mchan@broadcom.com, netdev@oss.sgi.com To: Jeff Garzik In-Reply-To: <424098E2.6090007@pobox.com> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, 22 Mar 2005 17:14:58 -0500 Jeff Garzik wrote: > OK, so this is not a tg3-related problem at all. Right. > It really sounds like you should update pci_msi_quirk() to cover the > other affected cases. That's not possible without either: 1) getting a lot of chipset vendors to reveal stuff they probably would rather keep secret (ie. that their chip in particular has MSI problems) 2) having a device on which to perform the MSI usability check See #2? That's the main issue from genericizing this, we need a device on which to perform the usability check so that we can handling a test interrupt and see if state got updated correctly. So for the time being, Michael's change is OK until we find a better solution that really does cover all the problem chipsets.