Re: [PATCH 2.6.11 4/8] tg3: Add msi test

["David S. Miller" <davem@davemloft.net>]

On Tue, 22 Mar 2005 17:26:44 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:

> I disagree: this will hide bugs.

It actually spots them too. :-)  If you'd like it to print out
something like:

	TG3 MSI test failed on chipset ven[%x] devid[%x] please
	email this info to PCI maintainers at x@y.com

that's fine.

> We already have a standard process in Linux to handle this stuff:
> 
> * avoid platform tests in the driver
> * when the driver fails, have the user try "pci=nomsi"
> * if that works, add system to blacklist

Just because it's what we've been doing doesn't mean it's the
best solution in this case.

If you hope users will just report this stuff, most of them won't.
They'll say Linux doesn't work on my computer and I have real life
stuff to take care of so I'll install freebsd or windows or a different
networking card and get on with life.

Eventually, say over a year or so, the database of bad chipsets will
get built with your scheme, but to much hardship and pain to users.