* [PATCH] use NETIF_F_LLTX in bonding device
@ 2005-03-15 18:29 Arthur Kepner
2005-03-23 2:46 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arthur Kepner @ 2005-03-15 18:29 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Lock contention on the bonding device's xmit_lock can
become a bottleneck when 3 or more gige links are aggregated.
And it looks like it's unnecessary too, so use the
NETIF_F_LLTX flag to avoid grabbing this lock.
Signed-off-by: <akepner@sgi.com>
--- linux.orig/drivers/net/bonding/bond_main.c 2005-03-14 14:08:29.000000000 -0800
+++ linux/drivers/net/bonding/bond_main.c 2005-03-14 17:08:57.000000000 -0800
@@ -4306,6 +4306,10 @@ static int __init bond_init(struct net_d
*/
bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
+ /* don't acquire bond device's xmit_lock when
+ * transmitting */
+ bond_dev->features |= NETIF_F_LLTX;
+
/* By default, we declare the bond to be fully
* VLAN hardware accelerated capable. Special
* care is taken in the various xmit functions
--
Arthur
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] use NETIF_F_LLTX in bonding device
2005-03-15 18:29 [PATCH] use NETIF_F_LLTX in bonding device Arthur Kepner
@ 2005-03-23 2:46 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-03-23 2:46 UTC (permalink / raw)
To: Arthur Kepner; +Cc: netdev
On Tue, 15 Mar 2005 10:29:16 -0800 (PST)
Arthur Kepner <akepner@sgi.com> wrote:
>
> Lock contention on the bonding device's xmit_lock can
> become a bottleneck when 3 or more gige links are aggregated.
> And it looks like it's unnecessary too, so use the
> NETIF_F_LLTX flag to avoid grabbing this lock.
>
> Signed-off-by: <akepner@sgi.com>
Yes, bonding does all of it's own internal locking, so this
change is correct.
Applied, thanks Arthur.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-23 2:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 18:29 [PATCH] use NETIF_F_LLTX in bonding device Arthur Kepner
2005-03-23 2:46 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).