From: Thomas Graf <tgraf@suug.ch>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, source@mvista.com
Subject: Re: [PATCH 1/7] [au1000]: Use netif_carrier_* instead of IFF_RUNNING
Date: Mon, 28 Mar 2005 03:20:10 +0200 [thread overview]
Message-ID: <20050328012010.GW3086@postel.suug.ch> (raw)
In-Reply-To: <20050328000658.GO3086@postel.suug.ch>
Correct patch checked-in this time.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/03/28 02:43:27+02:00 tgraf@suug.ch
# [au1000]: Use netif_carrier_* instead of IFF_RUNNING
#
# Signed-off-by: Thomas Graf <tgraf@suug.ch>
#
# drivers/net/au1000_eth.c
# 2005/03/28 02:43:16+02:00 tgraf@suug.ch +2 -8
# [au1000]: Use netif_carrier_* instead of IFF_RUNNING
#
diff -Nru a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
--- a/drivers/net/au1000_eth.c 2005-03-28 03:15:43 +02:00
+++ b/drivers/net/au1000_eth.c 2005-03-28 03:15:43 +02:00
@@ -1681,10 +1681,6 @@
control |= MAC_FULL_DUPLEX;
}
- /* fix for startup without cable */
- if (!link)
- dev->flags &= ~IFF_RUNNING;
-
aup->mac->control = control;
aup->mac->vlan1_tag = 0x8100; /* activate vlan support */
au_sync();
@@ -1709,16 +1705,14 @@
if_port = dev->if_port;
if (aup->phy_ops->phy_status(dev, aup->phy_addr, &link, &speed) == 0) {
if (link) {
- if (!(dev->flags & IFF_RUNNING)) {
+ if (!netif_carrier_ok(dev)) {
netif_carrier_on(dev);
- dev->flags |= IFF_RUNNING;
printk(KERN_INFO "%s: link up\n", dev->name);
}
}
else {
- if (dev->flags & IFF_RUNNING) {
+ if (netif_carrier_ok(dev)) {
netif_carrier_off(dev);
- dev->flags &= ~IFF_RUNNING;
dev->if_port = 0;
printk(KERN_INFO "%s: link down\n", dev->name);
}
next prev parent reply other threads:[~2005-03-28 1:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 0:06 [PATCHSET] IFF_RUNNING related fixes Thomas Graf
2005-03-28 0:06 ` [PATCH 1/7] [au1000]: Use netif_carrier_* instead of IFF_RUNNING Thomas Graf
2005-03-28 1:20 ` Thomas Graf [this message]
2005-03-31 1:22 ` Jeff Garzik
2005-03-28 0:07 ` [PATCH 2/7] [bmac]: Remove obsolete usage of IFF_RUNING Thomas Graf
2005-03-28 0:08 ` [PATCH 3/7] [tlan]: Use netif_carrier_* intead of IFF_RUNNING Thomas Graf
2005-03-28 0:08 ` [PATCH 4/7] [lmc]: Use netif_carrier_* instead " Thomas Graf
2005-03-28 0:09 ` [PATCH 5/7] [ibmtr]: Use netif_carrier_* instead of IFF_RUNNING and remove obsolete usage " Thomas Graf
2005-03-28 0:10 ` [PATCH 6/7] [sk98lin]: " Thomas Graf
2005-03-28 0:10 ` [PATCH 7/7] [NET]: Change comment to describe the real meaning " Thomas Graf
2005-03-28 0:15 ` [PATCHSET] IFF_RUNNING related fixes Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328012010.GW3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=source@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).