From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: Meelis Roos <mroos@linux.ee>, netdev <netdev@oss.sgi.com>
Subject: Re: cls_u32 compile failure in current 2.6.12-rc1+BK tree
Date: Mon, 28 Mar 2005 21:53:20 +0200 [thread overview]
Message-ID: <20050328195320.GE3086@postel.suug.ch> (raw)
In-Reply-To: <1112038128.1119.5.camel@jzny.localdomain>
* jamal <1112038128.1119.5.camel@jzny.localdomain> 2005-03-28 14:28
> On Mon, 2005-03-28 at 10:55, Thomas Graf wrote:
> > * jamal <1112015725.1089.1045.camel@jzny.localdomain> 2005-03-28 08:15
> > > On Mon, 2005-03-28 at 07:58, Thomas Graf wrote:
>
> > > But you cant completely do this for u32 tcf_exts_dump_stats.
> > > in the case of ACTION compiled in but someone using old API.
> > > The code that Meelis just mention that compiler complained about.
> > > There was no problem with u32 and tcf_exts_dump - with that you can hide
> > > all #ifedfs.
> >
> > I think we can avoid your fixes.
>
> You are still missing the question;->
>
> You can do this for every classifier but u32. Or is it me who is missing
> something?
I think what you are refering to is the TC_U32_KEY() check, right?
If you look at the place where tcf_exts_dump is called you can
see that the same pre condition is given since the call is in a
else branch of a TC_U32_KEY() == 0 condition.
I haven't had the time to come up with a patch, too many other
things to take care of but I think it should work out ok.
next prev parent reply other threads:[~2005-03-28 19:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 19:49 cls_u32 compile failure in current 2.6.12-rc1+BK tree Meelis Roos
2005-03-28 1:07 ` jamal
2005-03-28 7:18 ` Meelis Roos
2005-03-28 12:24 ` jamal
2005-03-28 12:38 ` Thomas Graf
2005-03-28 12:51 ` jamal
2005-03-28 12:58 ` Thomas Graf
2005-03-28 13:15 ` jamal
2005-03-28 15:55 ` Thomas Graf
2005-03-28 19:28 ` jamal
2005-03-28 19:53 ` Thomas Graf [this message]
2005-03-28 22:33 ` Thomas Graf
2005-03-29 1:10 ` Thomas Graf
2005-03-29 20:51 ` jamal
2005-03-30 1:02 ` Thomas Graf
2005-03-30 11:55 ` jamal
2005-03-31 0:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328195320.GE3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=hadi@cyberus.ca \
--cc=mroos@linux.ee \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).