From: Don Fry <brazilnut@us.ibm.com>
To: jgarzik@pobox.com, netdev@oss.sgi.com, akpm@osdl.org,
steven.hardy@astrium.eads.net
Subject: [PATCH 2.6.12-rc1] pcnet32: 79C975 fiber fix
Date: Mon, 28 Mar 2005 12:10:24 -0800 [thread overview]
Message-ID: <20050328201024.GA21408@us.ibm.com> (raw)
From: "HARDY, Steven" <steven.hardy@astrium.eads.net>
I have found a bug in the pcnet32 driver (drivers/net/pcnet32.c)
affecting all ethernet cards based on the AMD79C975 chip, using the
fiber interface.
It's a one line fix, where some config registers get corrupted during
initialisation (which stops the Fiber interface working with this chip)
This bug was introduced somewhere betweeen 2.4.17 and 2.6.x (noticed
whilst upgrading to 2.6), and it may affect other chips too. I have
checked all versions up to 2.6.11-bk6 and they are all broken.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Don Fry <brazilnut@us.ibm.com>
--- linux-2.6.12-rc1-bk1/drivers/net/orig.pcnet32.c 2005-03-23 10:19:04.000000000 -0800
+++ linux-2.6.12-rc1-bk1/drivers/net/pcnet32.c 2005-03-23 11:03:22.000000000 -0800
@@ -1351,7 +1351,8 @@ pcnet32_probe1(unsigned long ioaddr, int
printk(KERN_INFO "%s: registered as %s\n", dev->name, lp->name);
cards_found++;
- a->write_bcr(ioaddr, 2, 0x1002); /* enable LED writes */
+ /* enable LED writes */
+ a->write_bcr(ioaddr, 2, a->read_bcr(ioaddr, 2) | 0x1000);
return 0;
--
Don Fry
brazilnut@us.ibm.com
next reply other threads:[~2005-03-28 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 20:10 Don Fry [this message]
2005-03-31 1:14 ` [PATCH 2.6.12-rc1] pcnet32: 79C975 fiber fix Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328201024.GA21408@us.ibm.com \
--to=brazilnut@us.ibm.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=steven.hardy@astrium.eads.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).