From: Thomas Graf <tgraf@suug.ch>
To: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
Cc: netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH] rtnl_unlock/lock in sch_api.c TRY2
Date: Tue, 29 Mar 2005 03:29:01 +0200 [thread overview]
Message-ID: <20050329012901.GL3086@postel.suug.ch> (raw)
In-Reply-To: <Pine.LNX.4.62.0503290206500.3229@webhosting.rdsbv.ro>
* Catalin(ux aka Dino) BOIE <Pine.LNX.4.62.0503290206500.3229@webhosting.rdsbv.ro> 2005-03-29 02:09
> + replay:
> + tcm = NLMSG_DATA(n);
> + tca = arg;
> + clid = tcm->tcm_parent;
I know this has been in dave's patch already but why is this needed?
None of these variables changed in the meantime and the netlink message
should still be the same.
> + q = p = NULL;
There is also no way for q being != NULL here but I don't mind
if this stays as-is, both are supposed to be temporary variables.
Despite of these two comments the patch looks ok to me.
next prev parent reply other threads:[~2005-03-29 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 23:09 [PATCH] rtnl_unlock/lock in sch_api.c TRY2 Catalin(ux aka Dino) BOIE
2005-03-29 1:29 ` Thomas Graf [this message]
2005-03-29 6:33 ` Catalin(ux aka Dino) BOIE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329012901.GL3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).