From: "David S. Miller" <davem@davemloft.net>
To: John Heffner <jheffner@psc.edu>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] skb pcount with MTU discovery
Date: Fri, 1 Apr 2005 13:10:45 -0800 [thread overview]
Message-ID: <20050401131045.4e558f65.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0504011340510.17051@dexter.psc.edu>
On Fri, 1 Apr 2005 16:05:49 -0500 (EST)
John Heffner <jheffner@psc.edu> wrote:
> The problem is that when doing MTU discovery, the too-large segments in
> the write queue will be calculated as having a pcount of >1. When
> tcp_write_xmit() is trying to send, tcp_snd_test() fails the cwnd test
> when pcount > cwnd.
>
> The segments are eventually transmitted one at a time by keepalive, but
> this can take a long time.
>
> This patch checks if TSO is enabled when setting pcount.
Why isn't the MSS properly updated at this point in time?
If it were, the pcount setting would do the right thing.
That's how this code is supposed to work.
next prev parent reply other threads:[~2005-04-01 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 21:05 [PATCH] skb pcount with MTU discovery John Heffner
2005-04-01 21:10 ` David S. Miller [this message]
2005-04-01 21:22 ` John Heffner
2005-04-01 22:47 ` Herbert Xu
2005-04-02 15:32 ` John Heffner
2005-04-02 19:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050401131045.4e558f65.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jheffner@psc.edu \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).