netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: [PATCHSET] action statistics dumping fix & gnet_stats improvements
Date: Sat, 2 Apr 2005 01:26:54 +0200	[thread overview]
Message-ID: <20050401232654.GJ3086@postel.suug.ch> (raw)

Fixes a stupid bug I introduced in the last patchset which for some
reason didn't get caught in the testing process. The other two
patches change the behaviour of yet unused but likely use cases
to what one would expect without reading the code.

Please do a

	bk pull bk://kernel.bkbits.net/tgraf/net-2.6-tcf_exts

This will update the following files:

 include/net/gen_stats.h |    3 ++-
 net/core/gen_stats.c    |   48 +++++++++++++++++++++++++++++++-----------------
 net/sched/act_api.c     |    2 ++
 3 files changed, 35 insertions(+), 18 deletions(-)

through these ChangeSets:

<tgraf@suug.ch> (05/04/01 1.2181.44.3)
   [NET]: Improve gnet_stats_* dumping logic to be less error prone
   
   The recent additions to make gnet_stats_* useable for action
   statistics dumping in two steps introcuded a few error prone
   assumptions which can easly be forgotten. This patch fixes this
   up by simplifying the process of adding new fields to struct
   gnet_dump or adding additional backward compatibility TLVs.
   
   Signed-off-by: Thomas Graf <tgraf@suug.ch>
   Signed-off-by: David S. Miller <davem@davemloft.net>

<tgraf@suug.ch> (05/04/01 1.2181.44.2)
   [NET]: Allow dumping of application specific statistics if no primary TLV is used
   
   Although this case is hypothetical at the moment, more advanced actions are
   likely to need this in the future.
   
   Signed-off-by: Thomas Graf <tgraf@suug.ch>
   Signed-off-by: David S. Miller <davem@davemloft.net> 

<tgraf@suug.ch> (05/04/01 1.2181.44.1)
   [PKT_SCHED]: Properly return when no backward compatibility action statistics are to be dumped
   
   Fixes a stupid bug introcuded in my "Fix action statistics dumping in
   compatibility mode" patch, no clue why it actually worked without this fix.
   
   Signed-off-by: Thomas Graf <tgraf@suug.ch>
   Signed-off-by: David S. Miller <davem@davemloft.net>

             reply	other threads:[~2005-04-01 23:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-01 23:26 Thomas Graf [this message]
2005-04-01 23:27 ` [PATCH 1/3] [PKT_SCHED]: Properly return when no backward compatibility action statistics are to be dumped Thomas Graf
2005-04-01 23:28 ` [PATCH 2/3] [NET]: Allow dumping of application specific statistics if no primary TLV is used Thomas Graf
2005-04-01 23:28 ` [PATCH 3/3] [NET]: Improve gnet_stats_* dumping logic to be less error prone Thomas Graf
2005-04-01 23:49 ` [PATCHSET] action statistics dumping fix & gnet_stats improvements David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050401232654.GJ3086@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).