netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: [PATCH 1/3] [PKT_SCHED]: Properly return when no backward compatibility action statistics are to be dumped
Date: Sat, 2 Apr 2005 01:27:30 +0200	[thread overview]
Message-ID: <20050401232730.GK3086@postel.suug.ch> (raw)
In-Reply-To: <20050401232654.GJ3086@postel.suug.ch>

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2005/04/01 14:05:21+02:00 tgraf@suug.ch 
#   [PKT_SCHED]: Properly return when no backward compatibility action statistics are to be dumped
#   
#   Fixes a stupid bug introcuded in my "Fix action statistics dumping in
#   compatibility mode" patch, no clue why it actually worked without this fix.
#   
#   Signed-off-by: Thomas Graf <tgraf@suug.ch>
#   Signed-off-by: David S. Miller <davem@davemloft.net>
# 
# net/sched/act_api.c
#   2005/04/01 14:05:09+02:00 tgraf@suug.ch +2 -0
#   [PKT_SCHED]: Properly return when no backward compatibility action statistics are to be dumped
# 
diff -Nru a/net/sched/act_api.c b/net/sched/act_api.c
--- a/net/sched/act_api.c	2005-04-02 01:18:40 +02:00
+++ b/net/sched/act_api.c	2005-04-02 01:18:40 +02:00
@@ -397,6 +397,8 @@
 		if (a->type == TCA_OLD_COMPAT)
 			err = gnet_stats_start_copy_compat(skb, 0,
 				TCA_STATS, TCA_XSTATS, h->stats_lock, &d);
+		else
+			return 0;
 	} else
 		err = gnet_stats_start_copy(skb, TCA_ACT_STATS,
 			h->stats_lock, &d);

  reply	other threads:[~2005-04-01 23:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-01 23:26 [PATCHSET] action statistics dumping fix & gnet_stats improvements Thomas Graf
2005-04-01 23:27 ` Thomas Graf [this message]
2005-04-01 23:28 ` [PATCH 2/3] [NET]: Allow dumping of application specific statistics if no primary TLV is used Thomas Graf
2005-04-01 23:28 ` [PATCH 3/3] [NET]: Improve gnet_stats_* dumping logic to be less error prone Thomas Graf
2005-04-01 23:49 ` [PATCHSET] action statistics dumping fix & gnet_stats improvements David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050401232730.GK3086@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).