From: "David S. Miller" <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: herbert@gondor.apana.org.au, kaber@trash.net,
nakam@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: take 2-2 WAS(Re: PATCH: IPSEC xfrm events
Date: Mon, 4 Apr 2005 15:25:06 -0700 [thread overview]
Message-ID: <20050404152506.15e1404b.davem@davemloft.net> (raw)
In-Reply-To: <1112653217.1088.2.camel@jzny.localdomain>
On 04 Apr 2005 18:20:17 -0400
jamal <hadi@cyberus.ca> wrote:
> On Mon, 2005-04-04 at 17:31, Herbert Xu wrote:
> > On Mon, Apr 04, 2005 at 09:16:55AM -0400, jamal wrote:
> > >
> > > Ok, fair enough. It annoys me too when i review patches ;->
> > > So i will fix this before final.
> >
> > Just one more thing, can you please remove the _bh's that you
> > added to the read_lock for xfrm_km_list? It turns out that they're
> > not necessary since the write_lock()'s are only held in process
> > context.
>
> Doesnt the policy notification one need it at least ? I thought it is
> entered at interupt context on packet path, no?
If you only take write_lock() from process context, only the write_lock()'s
need BH disabling. read_lock() takers can then nest arbitrarily, BH or not.
next prev parent reply other threads:[~2005-04-04 22:25 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 1:37 PATCH: IPSEC xfrm events jamal
2005-04-01 4:21 ` Herbert Xu
2005-04-01 11:03 ` jamal
2005-04-01 11:42 ` Herbert Xu
2005-04-01 12:24 ` jamal
2005-04-01 12:35 ` Herbert Xu
2005-04-01 12:59 ` jamal
2005-04-01 13:18 ` jamal
2005-04-01 14:19 ` Masahide NAKAMURA
2005-04-02 1:04 ` jamal
2005-04-02 1:28 ` Herbert Xu
2005-04-02 1:42 ` jamal
2005-04-02 1:45 ` Herbert Xu
2005-04-02 1:46 ` Herbert Xu
2005-04-02 19:20 ` take 2 WAS(Re: " jamal
2005-04-03 14:31 ` jamal
2005-04-03 15:47 ` Patrick McHardy
2005-04-03 16:29 ` jamal
2005-04-03 16:36 ` jamal
2005-04-04 0:58 ` Herbert Xu
2005-04-04 1:56 ` jamal
2005-04-04 2:26 ` Herbert Xu
2005-04-04 2:39 ` jamal
2005-04-04 2:46 ` Herbert Xu
2005-04-04 3:05 ` jamal
2005-04-04 2:34 ` jamal
2005-04-04 2:52 ` Herbert Xu
2005-04-04 3:07 ` jamal
2005-04-04 11:38 ` take 2-2 " jamal
2005-04-04 12:16 ` Herbert Xu
2005-04-04 12:51 ` jamal
2005-04-04 13:02 ` Herbert Xu
2005-04-04 13:16 ` jamal
2005-04-04 21:31 ` Herbert Xu
2005-04-04 22:20 ` jamal
2005-04-04 22:25 ` David S. Miller [this message]
2005-04-04 22:42 ` jamal
2005-04-05 7:35 ` Masahide NAKAMURA
2005-04-05 10:18 ` jamal
2005-04-05 10:22 ` Herbert Xu
2005-04-05 10:35 ` jamal
2005-04-05 11:58 ` jamal
2005-04-05 17:46 ` David S. Miller
2005-04-05 18:05 ` jamal
2005-04-04 1:01 ` take 2 " Herbert Xu
2005-04-04 1:58 ` jamal
2005-04-04 2:27 ` Herbert Xu
2005-04-01 17:28 ` Masahide NAKAMURA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050404152506.15e1404b.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=nakam@linux-ipv6.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).