From: Thomas Graf <tgraf@suug.ch>
To: Wang Jian <lark@linux.net.cn>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] improvement on net/sched/cls_fw.c's hash function
Date: Tue, 5 Apr 2005 12:38:27 +0200 [thread overview]
Message-ID: <20050405103827.GL26731@postel.suug.ch> (raw)
In-Reply-To: <20050405140342.024A.LARK@linux.net.cn>
* Wang Jian <20050405140342.024A.LARK@linux.net.cn> 2005-04-05 14:05
> New patch attached. Hashsize is 256, the same as old one.
Do you have any numbers that could prove that this change
actually improves the hash distribution and thus the overall
lookup performance?
The most often used and thus most important range of mark
values is definitely 0..255. I did not look into jhash
but the risk of collisions definitely increases with this
change which affects about 90% of the users of fw which
could benefit from a collision free hashtable so far.
I would appreciate if you could provide some numbers proving
both the need and actual improvement of this change since
fwmark is one of the most often used classifiers.
Cheers
next prev parent reply other threads:[~2005-04-05 10:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 5:35 [PATCH] improvement on net/sched/cls_fw.c's hash function Wang Jian
2005-04-05 5:37 ` David S. Miller
2005-04-05 6:05 ` Wang Jian
2005-04-05 10:25 ` jamal
2005-04-05 10:38 ` Thomas Graf [this message]
2005-04-05 11:25 ` Wang Jian
2005-04-05 12:16 ` Thomas Graf
2005-04-05 12:39 ` Wang Jian
2005-04-05 12:52 ` Thomas Graf
2005-04-05 13:29 ` Wang Jian
2005-04-05 12:54 ` jamal
2005-04-05 14:18 ` Wang Jian
2005-04-05 16:11 ` jamal
2005-04-06 6:45 ` Wang Jian
2005-04-06 12:16 ` jamal
2005-04-06 12:30 ` Thomas Graf
2005-04-06 13:01 ` Wang Jian
2005-04-06 13:34 ` jamal
2005-04-06 13:45 ` Thomas Graf
2005-04-06 14:10 ` Thomas Graf
2005-04-06 18:15 ` David S. Miller
2005-04-06 18:31 ` Thomas Graf
2005-04-07 0:55 ` [RFC] dynamic hash table size & xor hash function for cls_fw Thomas Graf
2005-04-07 10:38 ` jamal
2005-04-07 10:47 ` Wang Jian
2005-04-07 10:51 ` Thomas Graf
2005-04-07 11:07 ` jamal
2005-04-07 13:09 ` [PATCH] [PKT_SCHED]: improve hashing performance of cls_fw Thomas Graf
2005-04-07 13:31 ` Wang Jian
2005-04-07 13:52 ` Thomas Graf
2005-04-07 14:03 ` Wang Jian
2005-04-06 13:36 ` [PATCH] improvement on net/sched/cls_fw.c's hash function Eran Mann
2005-04-06 13:53 ` Wang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405103827.GL26731@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=lark@linux.net.cn \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).