From: "David S. Miller" <davem@davemloft.net>
To: Christoph Lameter <christoph@lameter.com>
Cc: netdev@oss.sgi.com
Subject: Re: atomic_dec_and_test for child dst needed in dst_destroy?
Date: Tue, 5 Apr 2005 12:50:14 -0700 [thread overview]
Message-ID: <20050405125014.1ce46c66.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0504051238390.14264@server.graphe.net>
On Tue, 5 Apr 2005 12:47:09 -0700 (PDT)
Christoph Lameter <christoph@lameter.com> wrote:
> Correct that applies in general. But what could go wrong if the atomic_dec
> is separated from the atomic_read in this specific location?
>
> I fail to see what the point of having a single instance of
> atomic_dec_and_test for __refcnt is. In particular since the upper layers
> guarantee that dst_destroy is not called multiple times for the same dst
> entry.
If this is true, what performance improvement could you possibly be
seeing from this change?
I know you are making this change for performance reasons, yet you
aren't mentioning any details about this. That information is
part of what we need to know to judge this change.
I've very hesistant to undo atomic operation memory barriers, after
all of the weird problems we had in the neighbour cache.
next prev parent reply other threads:[~2005-04-05 19:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 18:55 atomic_dec_and_test for child dst needed in dst_destroy? Christoph Lameter
2005-04-05 19:34 ` David S. Miller
2005-04-05 19:47 ` Christoph Lameter
2005-04-05 19:50 ` David S. Miller [this message]
2005-04-05 19:58 ` Christoph Lameter
2005-04-05 20:12 ` David S. Miller
2005-04-05 21:45 ` Herbert Xu
2005-04-05 21:48 ` David S. Miller
2005-04-05 22:14 ` Christoph Lameter
2005-04-06 2:19 ` Herbert Xu
2005-04-06 3:19 ` Christoph Lameter
2005-04-06 8:32 ` Herbert Xu
2005-04-06 18:17 ` David S. Miller
2005-04-06 18:48 ` Christoph Lameter
2005-04-07 11:07 ` Herbert Xu
2005-04-07 16:00 ` Christoph Lameter
2005-04-07 21:25 ` Herbert Xu
2005-04-07 22:30 ` Christoph Lameter
2005-04-07 23:07 ` Herbert Xu
2005-04-08 5:45 ` Christoph Lameter
2005-04-08 5:48 ` Herbert Xu
2005-04-08 15:05 ` Christoph Lameter
2005-04-08 21:45 ` Herbert Xu
2005-04-09 15:28 ` Christoph Lameter
[not found] ` <b82a8917050406002339f732ca@mail.gmail.com>
2005-04-06 8:53 ` Fwd: " pravin b shelar
2005-04-07 11:23 ` Herbert Xu
2005-04-07 12:30 ` pravin b shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405125014.1ce46c66.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christoph@lameter.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).