netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH] netem: account for packets in delayed queue in qlen
Date: Tue, 5 Apr 2005 12:58:15 -0700	[thread overview]
Message-ID: <20050405125815.152cdbbc@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <4252EB9D.9070305@trash.net>

On Tue, 05 Apr 2005 21:48:45 +0200
Patrick McHardy <kaber@trash.net> wrote:

> Stephen Hemminger wrote:
> > Netem has a private queue for delayed packets, and currently, packets
> > in this queue are not accounted for in the qdisc qlen statistics.
> > This is a problem if netem is used inside another qdisc doing rate
> > control that peeks at the qlen.
> > 
> > This patch changes the statistics to include the packets held but
> > not ready to send.
> 
> There is one troublesome spot left, netem_watchdog() decreases q.qlen
> when the packet couldn't be enqueued. I don't think it is possible
> to make netem useable as leaf-qdisc, it will always have to touch
> q.qlen from timer context and classful qdiscs can't deal with this
> since they all maintain their own q.qlen counters and expect changes
> only in the +-1 range in enqueue/dequeue/requeue/drop. Best thing IMO
> would be to refuse to work as anything but root qdisc.

But then it won't work as a leaf off of prio to handle a single flow.

  reply	other threads:[~2005-04-05 19:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29 23:21 [PATCH] netem: account for packets in delayed queue in qlen Stephen Hemminger
2005-04-01  4:36 ` David S. Miller
2005-04-05 19:48 ` Patrick McHardy
2005-04-05 19:58   ` Stephen Hemminger [this message]
2005-04-07 19:04   ` Stephen Hemminger
2005-04-17 15:38     ` Patrick McHardy
2005-04-19  1:06       ` Stephen Hemminger
2005-04-20 14:00         ` Patrick McHardy
2005-04-21  3:20           ` Stephen Hemminger
2005-04-21 23:10             ` Patrick McHardy
2005-04-21 23:22               ` Stephen Hemminger
2005-04-21 23:39                 ` Patrick McHardy
2005-04-22  0:05                   ` jamal
2005-04-22  0:10                     ` Patrick McHardy
2005-04-22  0:32                       ` jamal
2005-04-22  0:40                         ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050405125815.152cdbbc@dxpl.pdx.osdl.net \
    --to=shemminger@osdl.org \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).