netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baruch Even <baruch@ev-en.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@oss.sgi.com
Subject: [PATCH] Too aggressive cwnd backoff
Date: Thu, 7 Apr 2005 19:41:46 +0300	[thread overview]
Message-ID: <20050407164146.GA6479@ev-en.org> (raw)

The cwnd backoff is down in two places and drops the cwnd to one quarter
instead of to one half.

On congestion events we reset tp->ssthresh to the result of
tcp_recalc_ssthresh. This cuts the cwnd by half for (New)Reno or to
a convoluted calculation for BIC.

Later we will call tcp_cwnd_down for each ack and reduce the cwnd by one
for every two acks.

However, in tcp_cwnd_down we will not stop reducing the cwnd until we
get to limit which is set to tp->ssthresh/2.

The provided patch will set limit to tp->ssthresh. This was the original
behaviour in some older version of Linux.

The patch is against 2.6.11

Signed-Off-By: Baruch Even <baruch@ev-en.org>

 net/ipv4/tcp_input.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.11-perf/net/ipv4/tcp_input.c
===================================================================
--- 2.6.11-perf.orig/net/ipv4/tcp_input.c
+++ 2.6.11-perf/net/ipv4/tcp_input.c
@@ -1621,7 +1621,7 @@ static void tcp_cwnd_down(struct tcp_soc
 	 */
 
 	if (!(limit = tcp_westwood_bw_rttmin(tp)))
-		limit = tp->snd_ssthresh/2;
+		limit = tp->snd_ssthresh;
 
 	tp->snd_cwnd_cnt = decr&1;
 	decr >>= 1;

             reply	other threads:[~2005-04-07 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-07 16:41 Baruch Even [this message]
2005-04-07 17:16 ` [PATCH] Too aggressive cwnd backoff Stephen Hemminger
2005-04-07 18:14   ` Baruch Even
2005-04-07 18:31     ` David S. Miller
2005-04-07 18:37       ` John Heffner
2005-04-08 21:33         ` Baruch Even
2005-04-07 20:26   ` Werner Almesberger
2005-04-07 18:33 ` David S. Miller
2005-04-07 19:18   ` Baruch Even
2005-04-07 20:37     ` David S. Miller
2005-04-07 21:42   ` Herbert Xu
2005-04-07 21:45     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050407164146.GA6479@ev-en.org \
    --to=baruch@ev-en.org \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).