From: Thomas Graf <tgraf@suug.ch>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: netdev@oss.sgi.com, Greg KH <greg@kroah.com>,
Jamal Hadi Salim <hadi@cyberus.ca>,
Kay Sievers <kay.sievers@vrfy.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
James Morris <jmorris@redhat.com>,
Guillaume Thouvenin <guillaume.thouvenin@bull.net>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Jay Lan <jlan@engr.sgi.com>
Subject: Re: [1/1] connector/CBUS: new messaging subsystem. Revision number next.
Date: Mon, 11 Apr 2005 15:32:39 +0200 [thread overview]
Message-ID: <20050411133239.GM26731@postel.suug.ch> (raw)
In-Reply-To: <20050411125932.GA19538@uganda.factory.vocord.ru>
* Evgeniy Polyakov <20050411125932.GA19538@uganda.factory.vocord.ru> 2005-04-11 16:59
> + size = NLMSG_SPACE(sizeof(*msg) + msg->len);
> +
> + skb = alloc_skb(size, gfp_mask);
> + if (!skb) {
> + printk(KERN_ERR "Failed to allocate new skb with size=%u.\n", size);
> + return -ENOMEM;
> + }
> +
> + nlh = NLMSG_PUT(skb, 0, msg->seq, NLMSG_DONE, size - sizeof(*nlh));
Needs same fix.
> + size0 = sizeof(*msg) + sizeof(*ctl) + 3*sizeof(*req);
> +
> + size = NLMSG_SPACE(size0);
> +
> + skb = alloc_skb(size, GFP_ATOMIC);
> + if (!skb) {
> + printk(KERN_ERR "Failed to allocate new skb with size=%u.\n", size);
> +
> + return -ENOMEM;
> + }
> +
> + nlh = NLMSG_PUT(skb, 0, 0x123, NLMSG_DONE, size - NLMSG_ALIGN(sizeof(*nlh)));
Just pass size0 instead of reverting the calculation.
next prev parent reply other threads:[~2005-04-11 13:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-11 12:59 [1/1] connector/CBUS: new messaging subsystem. Revision number next Evgeniy Polyakov
2005-04-11 13:32 ` Thomas Graf [this message]
2005-04-11 14:49 ` [2/1] " Evgeniy Polyakov
2005-04-26 15:57 ` [1/1] " Dmitry Torokhov
2005-04-26 16:24 ` Evgeniy Polyakov
2005-04-26 16:30 ` Evgeniy Polyakov
2005-04-26 17:34 ` Dmitry Torokhov
2005-04-26 18:07 ` Evgeniy Polyakov
2005-04-26 18:20 ` Dmitry Torokhov
2005-04-26 18:31 ` Evgeniy Polyakov
2005-04-26 18:42 ` Dmitry Torokhov
2005-04-26 18:48 ` Evgeniy Polyakov
2005-04-26 19:06 ` Dmitry Torokhov
2005-04-26 19:28 ` Evgeniy Polyakov
2005-04-26 20:02 ` Dmitry Torokhov
2005-04-27 4:06 ` Evgeniy Polyakov
2005-04-27 5:16 ` Dmitry Torokhov
2005-04-27 5:32 ` Evgeniy Polyakov
2005-04-27 5:46 ` Dmitry Torokhov
2005-04-27 6:08 ` Evgeniy Polyakov
2005-04-26 17:31 ` Dmitry Torokhov
2005-04-26 18:03 ` Evgeniy Polyakov
2005-04-26 18:10 ` Evgeniy Polyakov
2005-04-26 18:13 ` Evgeniy Polyakov
2005-04-26 18:25 ` Dmitry Torokhov
2005-04-26 18:35 ` Evgeniy Polyakov
2005-05-10 6:18 ` Dmitry Torokhov
2005-05-10 10:04 ` Evgeniy Polyakov
2005-05-10 14:56 ` Dmitry Torokhov
2005-05-10 15:41 ` Evgeniy Polyakov
2005-05-10 17:50 ` Dmitry Torokhov
2005-05-10 18:24 ` Evgeniy Polyakov
2005-05-11 5:46 ` Dmitry Torokhov
2005-05-11 6:48 ` Evgeniy Polyakov
2005-05-11 14:09 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050411133239.GM26731@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=guillaume.thouvenin@bull.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=jlan@engr.sgi.com \
--cc=jmorris@redhat.com \
--cc=johnpol@2ka.mipt.ru \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).