From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrian Bunk <bunk@stusta.de>
Subject: Re: [2.6 patch] drivers/net/wan/: possible cleanups
Date: Fri, 15 Apr 2005 01:20:28 +0200
Message-ID: <20050414232028.GD20400@stusta.de>
References: <20050327143418.GE4285@stusta.de> <1111941516.14877.325.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@oss.sgi.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Return-path: <linux-kernel-owner+glk-linux-kernel=40m.gmane.org-S261644AbVDNXUg@vger.kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Content-Disposition: inline
In-Reply-To: <1111941516.14877.325.camel@localhost.localdomain>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote:
> On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote:
> >   - syncppp.c: sppp_input
> >   - syncppp.c: sppp_change_mtu
> >   - z85230.c: z8530_dma_sync
> >   - z85230.c: z8530_txdma_sync
> 
> Please leave the z85230 ones at least. They are an intentional part of
> the external API for writing other 85230 card drivers.

If they are part of an API, why aren't the prototypes for them in any 
header file?

> Alan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed