Re: local_bh_enable & hard_start_xmit

["David S. Miller" <davem@davemloft.net>]

On Mon, 18 Apr 2005 15:59:05 -0700
Ben Greear <greearb@candelatech.com> wrote:

> This would be a good addition to the Documentation/networking/netdevices.txt
> file, or maybe to the dev.c file somewhere (I haven't found an complete list of
> locking notes, though the comments in the dev.c file and the netdevices.txt file
> are a big help.)

So write the patch to add such comments.  It would have taken the
same amount of typing as writing that paragraph saying how great an
addition this would be. :)

> I assume that it is fine to nest calls to local_bh_enable/disable?  (This
> seems to be required since you are supposed to have bh disabled when
> calling hard_start_xmit, but hard_start_xmit can call dev_queue_xmit which
> disables the bh again...)

Yes, this is legal, BH disabling does nest properly.