* 2.6.12-rc2-mm3: hostap: do not #include .c files [not found] <20050411012532.58593bc1.akpm@osdl.org> @ 2005-04-19 2:03 ` Adrian Bunk 2005-04-19 2:12 ` Jouni Malinen 0 siblings, 1 reply; 2+ messages in thread From: Adrian Bunk @ 2005-04-19 2:03 UTC (permalink / raw) To: Andrew Morton, jkmaline; +Cc: linux-kernel, hostap, jgarzik, netdev On Mon, Apr 11, 2005 at 01:25:32AM -0700, Andrew Morton wrote: >... > All 819 patches: >... > bk-netdev.patch >... drivers/net/wireless/hostap/hostap.c:#include "hostap_crypt.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_ap.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_info.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_ioctl.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_proc.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_80211_rx.c" drivers/net/wireless/hostap/hostap.c:#include "hostap_80211_tx.c" drivers/net/wireless/hostap/hostap_cs.c:#include "hostap_hw.c" drivers/net/wireless/hostap/hostap_hw.c:#include "hostap_download.c" drivers/net/wireless/hostap/hostap_hw.c:#include "hostap_callback.c" drivers/net/wireless/hostap/hostap_pci.c:#include "hostap_hw.c" drivers/net/wireless/hostap/hostap_plx.c:#include "hostap_hw.c" Please do not #include .c files. A proper separation in a .c file and a header file is the better solution. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.12-rc2-mm3: hostap: do not #include .c files 2005-04-19 2:03 ` 2.6.12-rc2-mm3: hostap: do not #include .c files Adrian Bunk @ 2005-04-19 2:12 ` Jouni Malinen 0 siblings, 0 replies; 2+ messages in thread From: Jouni Malinen @ 2005-04-19 2:12 UTC (permalink / raw) To: Adrian Bunk; +Cc: Andrew Morton, jgarzik, hostap, linux-kernel, netdev On Tue, Apr 19, 2005 at 04:03:12AM +0200, Adrian Bunk wrote: > drivers/net/wireless/hostap/hostap.c:#include "hostap_crypt.c" > Please do not #include .c files. A tested patch would be appreciated.. ;-) > A proper separation in a .c file and a header file is the better > solution. Agreed and this is on my to-do list, but not very high on it. Some of these would be relatively easy to fix, but the hardware specific ones (different register offsets for PC Card/PLX/PCI) would require quite a bit of changes to get rid of this. -- Jouni Malinen PGP id EFC895FA ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-04-19 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20050411012532.58593bc1.akpm@osdl.org>
2005-04-19 2:03 ` 2.6.12-rc2-mm3: hostap: do not #include .c files Adrian Bunk
2005-04-19 2:12 ` Jouni Malinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).