From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
jgarzik@pobox.com, hostap@shmoo.com,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: 2.6.12-rc2-mm3: hostap: do not #include .c files
Date: Mon, 18 Apr 2005 19:12:38 -0700 [thread overview]
Message-ID: <20050419021238.GG8267@jm.kir.nu> (raw)
In-Reply-To: <20050419020312.GR5489@stusta.de>
On Tue, Apr 19, 2005 at 04:03:12AM +0200, Adrian Bunk wrote:
> drivers/net/wireless/hostap/hostap.c:#include "hostap_crypt.c"
> Please do not #include .c files.
A tested patch would be appreciated.. ;-)
> A proper separation in a .c file and a header file is the better
> solution.
Agreed and this is on my to-do list, but not very high on it. Some of
these would be relatively easy to fix, but the hardware specific ones
(different register offsets for PC Card/PLX/PCI) would require quite a
bit of changes to get rid of this.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2005-04-19 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050411012532.58593bc1.akpm@osdl.org>
2005-04-19 2:03 ` 2.6.12-rc2-mm3: hostap: do not #include .c files Adrian Bunk
2005-04-19 2:12 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419021238.GG8267@jm.kir.nu \
--to=jkmaline@cc.hut.fi \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=hostap@shmoo.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).