* [2.6 patch] drivers/net/hamradio/: cleanups
@ 2005-04-19 2:40 Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-04-19 2:40 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, netdev
This patch contains the following cleanups:
- mkiss.c: make a needlessly global variable static
- dmascc.c: remove the unused global function dmascc_setup
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/hamradio/dmascc.c | 10 ----------
drivers/net/hamradio/mkiss.c | 2 +-
2 files changed, 1 insertion(+), 11 deletions(-)
--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c.old 2005-04-19 03:04:36.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c 2005-04-19 03:04:57.000000000 +0200
@@ -311,16 +311,6 @@
}
}
-#ifndef MODULE
-void __init dmascc_setup(char *str, int *ints)
-{
- int i;
-
- for (i = 0; i < MAX_NUM_DEVS && i < ints[0]; i++)
- io[i] = ints[i + 1];
-}
-#endif
-
static int __init dmascc_init(void)
{
int h, i, j, n;
--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c.old 2005-04-19 03:05:20.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c 2005-04-19 03:05:30.000000000 +0200
@@ -65,7 +65,7 @@
static ax25_ctrl_t **ax25_ctrls;
-int ax25_maxdev = AX25_MAXDEV; /* Can be overridden with insmod! */
+static int ax25_maxdev = AX25_MAXDEV; /* Can be overridden with insmod! */
static struct tty_ldisc ax_ldisc;
^ permalink raw reply [flat|nested] 7+ messages in thread* [2.6 patch] drivers/net/hamradio/: cleanups
@ 2005-05-02 1:46 Adrian Bunk
2005-06-26 22:26 ` Jeff Garzik
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-05-02 1:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeff Garzik, linux-kernel, netdev
This patch contains the following cleanups:
- mkiss.c: make a needlessly global variable static
- dmascc.c: remove the unused global function dmascc_setup
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 19 Apr 2005
drivers/net/hamradio/dmascc.c | 10 ----------
drivers/net/hamradio/mkiss.c | 2 +-
2 files changed, 1 insertion(+), 11 deletions(-)
--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c.old 2005-04-19 03:04:36.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c 2005-04-19 03:04:57.000000000 +0200
@@ -311,16 +311,6 @@
}
}
-#ifndef MODULE
-void __init dmascc_setup(char *str, int *ints)
-{
- int i;
-
- for (i = 0; i < MAX_NUM_DEVS && i < ints[0]; i++)
- io[i] = ints[i + 1];
-}
-#endif
-
static int __init dmascc_init(void)
{
int h, i, j, n;
--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c.old 2005-04-19 03:05:20.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c 2005-04-19 03:05:30.000000000 +0200
@@ -65,7 +65,7 @@
static ax25_ctrl_t **ax25_ctrls;
-int ax25_maxdev = AX25_MAXDEV; /* Can be overridden with insmod! */
+static int ax25_maxdev = AX25_MAXDEV; /* Can be overridden with insmod! */
static struct tty_ldisc ax_ldisc;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] drivers/net/hamradio/: cleanups
2005-05-02 1:46 Adrian Bunk
@ 2005-06-26 22:26 ` Jeff Garzik
2005-06-26 22:38 ` Adrian Bunk
2005-06-26 22:53 ` randy_dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Jeff Garzik @ 2005-06-26 22:26 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, netdev
Adrian Bunk wrote:
> This patch contains the following cleanups:
> - dmascc.c: remove the unused global function dmascc_setup
Better to use it, then remove it.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/net/hamradio/: cleanups
2005-06-26 22:26 ` Jeff Garzik
@ 2005-06-26 22:38 ` Adrian Bunk
2005-06-26 22:53 ` randy_dunlap
1 sibling, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-06-26 22:38 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, linux-kernel, netdev
On Sun, Jun 26, 2005 at 06:26:49PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >This patch contains the following cleanups:
> >- dmascc.c: remove the unused global function dmascc_setup
>
> Better to use it, then remove it.
Can you give me a hint how it should be used?
Why doesn't dmascc_init together with the MODULE_PARM(io,...) work in
the non-modular case?
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] drivers/net/hamradio/: cleanups
2005-06-26 22:26 ` Jeff Garzik
2005-06-26 22:38 ` Adrian Bunk
@ 2005-06-26 22:53 ` randy_dunlap
2005-06-26 23:00 ` Jeff Garzik
1 sibling, 1 reply; 7+ messages in thread
From: randy_dunlap @ 2005-06-26 22:53 UTC (permalink / raw)
To: Jeff Garzik; +Cc: bunk, akpm, linux-kernel, netdev
On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:
| Adrian Bunk wrote:
| > This patch contains the following cleanups:
| > - dmascc.c: remove the unused global function dmascc_setup
|
| Better to use it, then remove it.
than ??
---
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] drivers/net/hamradio/: cleanups
2005-06-26 22:53 ` randy_dunlap
@ 2005-06-26 23:00 ` Jeff Garzik
2005-07-23 17:08 ` Adrian Bunk
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Garzik @ 2005-06-26 23:00 UTC (permalink / raw)
To: randy_dunlap; +Cc: bunk, akpm, linux-kernel, netdev
randy_dunlap wrote:
> On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:
>
> | Adrian Bunk wrote:
> | > This patch contains the following cleanups:
> | > - dmascc.c: remove the unused global function dmascc_setup
> |
> | Better to use it, then remove it.
>
> than ??
Yes. Use it via __setup() or similar.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/net/hamradio/: cleanups
2005-06-26 23:00 ` Jeff Garzik
@ 2005-07-23 17:08 ` Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-07-23 17:08 UTC (permalink / raw)
To: Jeff Garzik; +Cc: randy_dunlap, akpm, linux-kernel, netdev
On Sun, Jun 26, 2005 at 07:00:13PM -0400, Jeff Garzik wrote:
> randy_dunlap wrote:
> >On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:
> >
> >| Adrian Bunk wrote:
> >| > This patch contains the following cleanups:
> >| > - dmascc.c: remove the unused global function dmascc_setup
> >|
> >| Better to use it, then remove it.
> >
> > than ??
>
> Yes. Use it via __setup() or similar.
Hi Jeff,
I still haven't gotten any answer from you regarding the following
question:
Can you give me a hint how it should be used?
Why doesn't dmascc_init together with the MODULE_PARM(io,...) work in
the non-modular case?
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-07-23 17:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-19 2:40 [2.6 patch] drivers/net/hamradio/: cleanups Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-05-02 1:46 Adrian Bunk
2005-06-26 22:26 ` Jeff Garzik
2005-06-26 22:38 ` Adrian Bunk
2005-06-26 22:53 ` randy_dunlap
2005-06-26 23:00 ` Jeff Garzik
2005-07-23 17:08 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).