From: Benjamin LaHaise <bcrl@kvack.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: jgarzik@pobox.com, linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [2.6 patch] kill include/linux/eeprom.h
Date: Tue, 19 Apr 2005 09:56:48 -0400 [thread overview]
Message-ID: <20050419135648.GC7315@kvack.org> (raw)
In-Reply-To: <20050419012935.GQ5489@stusta.de>
At the very least your patch doesn't do a thorough enough job of
removing the dead code -- there is no good reason to move the unused
code into ns83820.c.
Also, someone needs to go around refactoring eeprom code out of the
network drivers at some point.
-ben
next prev parent reply other threads:[~2005-04-19 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 1:29 [2.6 patch] kill include/linux/eeprom.h Adrian Bunk
2005-04-19 13:56 ` Benjamin LaHaise [this message]
2005-04-19 14:09 ` Nick Winlund
2005-04-19 23:56 ` Adrian Bunk
2005-04-20 14:42 ` Benjamin LaHaise
-- strict thread matches above, loose matches on Subject: below --
2005-11-05 19:01 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419135648.GC7315@kvack.org \
--to=bcrl@kvack.org \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).