From: Adrian Bunk <bunk@stusta.de>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: jgarzik@pobox.com, linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [2.6 patch] kill include/linux/eeprom.h
Date: Wed, 20 Apr 2005 01:56:46 +0200 [thread overview]
Message-ID: <20050419235646.GY5489@stusta.de> (raw)
In-Reply-To: <20050419135648.GC7315@kvack.org>
On Tue, Apr 19, 2005 at 09:56:48AM -0400, Benjamin LaHaise wrote:
> At the very least your patch doesn't do a thorough enough job of
> removing the dead code -- there is no good reason to move the unused
> code into ns83820.c.
Where does my patch do this?
Only the one actually used function setup_ee_mem_bitbanger is moved to
ns83820.c .
> Also, someone needs to go around refactoring eeprom code out of the
> network drivers at some point.
I have no problem with this, but it has to be done right.
> -ben
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-04-19 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 1:29 [2.6 patch] kill include/linux/eeprom.h Adrian Bunk
2005-04-19 13:56 ` Benjamin LaHaise
2005-04-19 14:09 ` Nick Winlund
2005-04-19 23:56 ` Adrian Bunk [this message]
2005-04-20 14:42 ` Benjamin LaHaise
-- strict thread matches above, loose matches on Subject: below --
2005-11-05 19:01 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419235646.GY5489@stusta.de \
--to=bunk@stusta.de \
--cc=bcrl@kvack.org \
--cc=jgarzik@pobox.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).