From: Thomas Graf <tgraf@suug.ch>
To: Asim Shankar <asimshankar@gmail.com>
Cc: netdev@oss.sgi.com, devik@cdi.cz
Subject: Re: [PATCH] - sch_htb: Drop packet when direct queue overflows
Date: Thu, 21 Apr 2005 23:54:40 +0200 [thread overview]
Message-ID: <20050421215440.GL577@postel.suug.ch> (raw)
In-Reply-To: <7bca1cb505042113417a5d9f59@mail.gmail.com>
[CCed Martin Devera]
* Asim Shankar <7bca1cb505042113417a5d9f59@mail.gmail.com> 2005-04-21 15:41
> Patched pasted and attached:
For patch formatting details see http://linux.yyz.us/patch-format.html
A short description of the patch would be helpful.
Besides of that...
Signed-off-by: Thomas Graf <tgraf@suug.ch>
> --- linux-2.6.11.7/net/sched/sch_htb.c 2005-04-07 13:57:45.000000000 -0500
> +++ linux-2.6.11.7-new/net/sched/sch_htb.c 2005-04-21 14:17:36.272065816 -0500
> @@ -717,6 +717,10 @@
> if (q->direct_queue.qlen < q->direct_qlen) {
> __skb_queue_tail(&q->direct_queue, skb);
> q->direct_pkts++;
> + } else {
> + kfree_skb (skb);
Could you write this without the whitespace?
> + sch->qstats.drops++;
> + return NET_XMIT_DROP;
> }
> #ifdef CONFIG_NET_CLS_ACT
> } else if (!cl) {
Thanks.
next prev parent reply other threads:[~2005-04-21 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 19:21 BUG: HTB? Asim Shankar
2005-04-21 19:56 ` Thomas Graf
2005-04-21 20:41 ` [PATCH] - sch_htb: Drop packet when direct queue overflows Asim Shankar
2005-04-21 21:54 ` Thomas Graf [this message]
2005-04-21 23:02 ` [PATCH 2.6.11.7] sch_htb: Drop packet when direct queue is full Asim Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050421215440.GL577@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=asimshankar@gmail.com \
--cc=devik@cdi.cz \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).