netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: jmoyer@redhat.com, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH 4/7] netpoll: fix ->poll() locking
Date: Fri, 22 Apr 2005 19:14:40 -0700	[thread overview]
Message-ID: <20050423021440.GZ21897@waste.org> (raw)
In-Reply-To: <20050422155958.474a150c.davem@davemloft.net>

On Fri, Apr 22, 2005 at 03:59:58PM -0700, David S. Miller wrote:
> On Fri, 22 Apr 2005 19:02:43 -0400
> Jeff Moyer <jmoyer@redhat.com> wrote:
> 
> > Oh yes, of course.  Somehow I managed to forget that we now squirrel away
> > the struct netpoll pointer in the net_device.  Previously you could
> > register multiple netpoll clients to one device, and this was useful for
> > say doing netconsole and netdump over the same interface.  If we've removed
> > this ability, this is a bad thing.  Oh dear...

Hrm, it appears I forgot about that when I did the recent rework.

> In such a configuration, how did the netpoll code "tell" who the
> receive packets were for or did it send them to all registered
> netpoll clients for that device?

It walked a global list of clients.

-- 
Mathematics is the supreme nostalgia of our time.

  reply	other threads:[~2005-04-23  2:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-03 20:46 [PATCH 0/7] netpoll: recursion fixes, queueing, and cleanups Matt Mackall
2005-03-03 20:46 ` [PATCH 1/7] netpoll: shorten carrier detect timeout Matt Mackall
2005-03-03 20:46   ` [PATCH 2/7] netpoll: filter inlines Matt Mackall
2005-03-03 20:46     ` [PATCH 3/7] netpoll: add netpoll point to net_device Matt Mackall
2005-03-03 20:46       ` [PATCH 4/7] netpoll: fix ->poll() locking Matt Mackall
2005-03-03 20:46         ` [PATCH 5/7] netpoll: add optional dropping and queueing support Matt Mackall
2005-03-03 20:46           ` [PATCH 6/7] netpoll: handle xmit_lock recursion similarly Matt Mackall
2005-03-03 20:46             ` [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo Matt Mackall
2005-03-03 21:00               ` David S. Miller
2005-03-03 21:17                 ` Jeff Garzik
2005-03-03 21:29                   ` David S. Miller
2005-03-03 21:33                     ` Jeff Garzik
2005-03-03 21:39                     ` Matt Mackall
2005-03-03 21:41                       ` David S. Miller
2005-03-03 21:32                 ` Matt Mackall
2005-03-23  2:35                   ` David S. Miller
2005-04-22 22:24         ` [PATCH 4/7] netpoll: fix ->poll() locking Jeff Moyer
2005-04-22 22:52           ` David S. Miller
2005-04-22 23:02             ` Jeff Moyer
2005-04-22 22:59               ` David S. Miller
2005-04-23  2:14                 ` Matt Mackall [this message]
2005-04-23  5:12                   ` David S. Miller
2005-03-06  0:09   ` [PATCH 1/7] netpoll: shorten carrier detect timeout Patrick McHardy
2005-03-06  0:20     ` Matt Mackall
2005-03-06  1:01       ` Patrick McHardy
2005-03-10 23:01         ` Matt Mackall
2005-03-11  4:35           ` Patrick McHardy
2005-03-11  4:42             ` Matt Mackall
2005-03-11  4:53               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050423021440.GZ21897@waste.org \
    --to=mpm@selenic.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=jmoyer@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).