From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/net/seeq8005.c: cleanups
Date: Mon, 2 May 2005 03:46:24 +0200 [thread overview]
Message-ID: <20050502014624.GL3592@stusta.de> (raw)
This patch contains the following cleanups:
- make the needlessly global function seeq8005_init static
- kill an ancient version variable
- remove some outdated Emacs settings
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 19 Apr 2005
- 21 Feb 2005
drivers/net/seeq8005.c | 23 ++---------------------
1 files changed, 2 insertions(+), 21 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c.old 2005-02-16 18:18:56.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c 2005-02-21 15:19:11.000000000 +0100
@@ -12,12 +12,6 @@
This file is a network device driver for the SEEQ 8005 chipset and
the Linux operating system.
-*/
-
-static const char version[] =
- "seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@zot.apana.org.au)\n";
-
-/*
Sources:
SEEQ 8005 databook
@@ -91,7 +85,7 @@
/* Example routines you must write ;->. */
#define tx_done(dev) (inw(SEEQ_STATUS) & SEEQSTAT_TX_ON)
static void hardware_send_packet(struct net_device *dev, char *buf, int length);
-extern void seeq8005_init(struct net_device *dev, int startp);
+static void seeq8005_init(struct net_device *dev, int startp);
static inline void wait_for_buffer(struct net_device *dev);
\f
@@ -150,7 +144,6 @@
static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
{
- static unsigned version_printed;
int i,j;
unsigned char SA_prom[32];
int old_cfg1;
@@ -291,9 +284,6 @@
}
#endif
- if (net_debug && version_printed++ == 0)
- printk(version);
-
printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
/* Fill in the 'dev' fields. */
@@ -637,7 +627,7 @@
#endif
}
-void seeq8005_init(struct net_device *dev, int startp)
+static void seeq8005_init(struct net_device *dev, int startp)
{
struct net_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
@@ -758,12 +748,3 @@
}
#endif /* MODULE */
-\f
-/*
- * Local variables:
- * compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- * version-control: t
- * kept-new-versions: 5
- * tab-width: 4
- * End:
- */
next reply other threads:[~2005-05-02 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-02 1:46 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-19 0:36 [2.6 patch] drivers/net/seeq8005.c: cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050502014624.GL3592@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).