From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: tgraf@suug.ch, nicolas.dichtel@6wind.com, netdev@oss.sgi.com,
linux-net@vger.kernel.org
Subject: Re: Question about QOS
Date: Tue, 3 May 2005 14:40:32 -0700 [thread overview]
Message-ID: <20050503144032.25ea921d.davem@davemloft.net> (raw)
In-Reply-To: <427225B2.6010705@trash.net>
On Fri, 29 Apr 2005 14:16:50 +0200
Patrick McHardy <kaber@trash.net> wrote:
> Thomas Graf wrote:
> > * Nicolas DICHTEL <426F42F0.9020609@6wind.com> 2005-04-27 09:44
> >
> >>>Yes I agree, it doesn't really matter what value we return and `bound'
> >>>is most likely to be correct. I think we should also fix the unlikely
> >>>but still possible case when tv1.tv_usec is slightly smaller than
> >>>tv2.tv_usec. I know it is very unlikely but do_gettimeofday really
> >>>is not that reliable and we have users which rely on a positive
> >>>delta. Can you extend your patch to return abs(delta) for case 0
> >>>in PSCHED_TDIFF_SAFE?
>
> Why abs(delta)? It could be above bound, in fact all cases besides
> delta_sec > 2 doesn't take care to stay inside [0..bound] at all.
Applied, thanks Patrick.
prev parent reply other threads:[~2005-05-03 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 9:16 Question about QOS Nicolas DICHTEL
2005-04-26 12:59 ` Thomas Graf
2005-04-26 14:57 ` Nicolas DICHTEL
2005-04-26 19:14 ` Thomas Graf
2005-04-27 7:44 ` Nicolas DICHTEL
2005-04-27 11:42 ` Thomas Graf
2005-04-28 19:14 ` David S. Miller
2005-04-29 12:16 ` Patrick McHardy
2005-04-29 12:39 ` Thomas Graf
2005-05-03 21:40 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050503144032.25ea921d.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=nicolas.dichtel@6wind.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).