From: Thomas Graf <tgraf@suug.ch>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 1/3] [RTNETLINK] Fix RTM_MAX to represent the maximum valid message type
Date: Wed, 4 May 2005 01:02:17 +0200 [thread overview]
Message-ID: <20050503230217.GR577@postel.suug.ch> (raw)
In-Reply-To: <20050503152704.4c6744d6.davem@davemloft.net>
* David S. Miller <20050503152704.4c6744d6.davem@davemloft.net> 2005-05-03 15:27
> On Wed, 4 May 2005 00:20:03 +0200
> Thomas Graf <tgraf@suug.ch> wrote:
>
> > * David S. Miller <20050503142740.345925ea.davem@davemloft.net> 2005-05-03 14:27
> > > Excellent observation. The fact that we encode the "modifies state"
> > > in the low bits of the RTM_* numbers has always been a source of
> > > obscure bugs and hard to track down errors.
> > >
> > > Patch applied, thanks.
> >
> > Do you want 2.4 backports for all patches or just the xfrm
> > off-by-one fix?
>
> Congratulations if you can find xfrm in the vanilla
> 2.4.x tree :-)
Heh, ok ok ;-> I think none of the patches need to be backported
then, although the type > RTM_MAX has an off-by-one issue the
current RTM_MAX is set to one below the start of the next block
so the behaviour matches the 2.6 tree.
prev parent reply other threads:[~2005-05-03 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-30 19:50 [PATCH 1/3] [RTNETLINK] Fix RTM_MAX to represent the maximum valid message type Thomas Graf
2005-05-03 21:27 ` David S. Miller
2005-05-03 22:20 ` Thomas Graf
2005-05-03 22:27 ` David S. Miller
2005-05-03 23:02 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050503230217.GR577@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).