From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class Date: Thu, 05 May 2005 18:55:03 +0900 (JST) Message-ID: <20050505.185503.78606493.yoshfuji@linux-ipv6.org> References: <42798AC1.2010308@cs.wisc.edu> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-scsi@vger.kernel.org, netdev@oss.sgi.com, linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org Return-path: To: michaelc@cs.wisc.edu In-Reply-To: <42798AC1.2010308@cs.wisc.edu> Sender: linux-scsi-owner@vger.kernel.org List-Id: netdev.vger.kernel.org In article <42798AC1.2010308@cs.wisc.edu> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie says: > +struct iscsi_uevent { : > +} __attribute__ ((aligned (sizeof(unsigned long)))); I think it'd be better to use sizeof(uint64_t) or something. Please check other spots, too. e.g.: > + struct iscsi_stats_custom custom[0] > + __attribute__ ((aligned (sizeof(unsigned long)))); --yoshfuji