From: "David S. Miller" <davem@davemloft.net>
To: "Michael Chan" <mchan@broadcom.com>
Cc: shemminger@osdl.org, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: Mystery packet killing tg3
Date: Thu, 5 May 2005 14:42:01 -0700 [thread overview]
Message-ID: <20050505144201.389edfd4.davem@davemloft.net> (raw)
In-Reply-To: <1115322994.15156.98.camel@rh4>
On Thu, 05 May 2005 12:56:34 -0700
"Michael Chan" <mchan@broadcom.com> wrote:
> On Thu, 2005-05-05 at 11:33 -0700, David S. Miller wrote:
>
> > I'm very tempted to add a silencer to these messages in these
> > cases. Something like the patch below. Michael, what do you
> > think?
> >
> > [TG3]: Elide tg3_stop_block messages when such events are normal.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
>
> Looks good. I'm adding this patch to further ignore the tg3_stop_block
> errors.
>
> [TG3]: Ignore tg3_stop_block() errors.
>
> tg3_stop_block() errors can be safely ignored since tg3_chip_reset()
> always follows tg3_stop_block() calls.
Your email client wrapped the lines in the patch Michael, please use
attachments if you can't avoid this.
Anyways, I applied both my patch and your's (by hand) to my tree and
will push upstream.
Thanks again.
next prev parent reply other threads:[~2005-05-05 21:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 6:27 Mystery packet killing tg3 Michael Chan
2005-05-04 22:51 ` Stephen Hemminger
2005-05-04 22:30 ` Michael Chan
[not found] ` <20050505113356.0f1b4c00.davem@davemloft.net>
2005-05-05 19:56 ` Michael Chan
2005-05-05 21:42 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-04 6:09 Michael Chan
2005-05-02 23:24 Stephen Hemminger
2005-05-03 3:02 ` David S. Miller
2005-05-03 21:05 ` Stephen Hemminger
2005-05-03 21:13 ` David S. Miller
2005-05-03 20:41 ` Michael Chan
2005-05-03 22:03 ` David S. Miller
2005-05-03 21:28 ` Michael Chan
2005-05-03 22:53 ` David S. Miller
2005-05-03 22:45 ` Stephen Hemminger
2005-05-03 22:39 ` David S. Miller
2005-05-03 22:59 ` Stephen Hemminger
2005-05-03 21:29 ` Stephen Hemminger
2005-05-04 18:30 ` Andi Kleen
2005-05-04 18:44 ` Peter Buckingham
2005-05-05 11:43 ` Andi Kleen
2005-05-05 16:20 ` Stephen Hemminger
2005-05-05 18:01 ` Andi Kleen
2005-05-05 17:09 ` Peter Buckingham
2005-05-05 17:32 ` Rick Jones
2005-05-05 17:38 ` Peter Buckingham
2005-05-05 17:45 ` John Heffner
2005-05-05 18:06 ` Andi Kleen
2005-05-05 18:21 ` Peter Buckingham
2005-05-05 18:31 ` Andi Kleen
2005-05-05 18:40 ` Peter Buckingham
2005-05-05 18:56 ` Andi Kleen
2005-05-05 19:02 ` Peter Buckingham
2005-05-05 19:24 ` Andi Kleen
2005-05-04 19:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505144201.389edfd4.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).