From: Anton Blanchard <anton@samba.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] TSO Reloaded
Date: Fri, 6 May 2005 17:10:05 +1000 [thread overview]
Message-ID: <20050506071005.GG8255@krispykreme> (raw)
In-Reply-To: <20050505231345.4296d9b5.davem@davemloft.net>
> I know what is causing the breaks, it's the "cache line align" crap
> in tcp_sendmsg().
>
> Comment out this alignment code in net/ipv4/tcp.c and see how it goes:
>
> /* If page is cached, align
> * offset to L1 cache boundary
> */
> off = (off + L1_CACHE_BYTES - 1) &
> ~(L1_CACHE_BYTES - 1);
>
> This alignment causes TSO coalescing to fail at these spots.
>
> You should not see this effect when sendfile() is used for
> the transfer.
Nice work! Its looking much better now.
Anton
1500 MTU:
eth0 data: 74 frags:
eth0 data: 66 frags: 2892 4
eth0 data: 66 frags: 1200 1692 4
eth0 data: 66 frags: 2400 492 4
eth0 data: 66 frags: 2892 4
eth0 data: 66 frags: 704 744
eth0 data: 66 frags: 3352 4096 1236 4
eth0 data: 66 frags: 2856 36 4
1500 MTU+sendfile:
eth0 data: 74 frags:
eth0 data: 66 frags: 2892 4
eth0 data: 66 frags: 1200 1692 4
eth0 data: 66 frags: 2400 492 4
eth0 data: 66 frags: 2892 4
eth0 data: 66 frags: 704 744
eth0 data: 66 frags: 3348 4
eth0 data: 66 frags: 4092 4
9000 MTU:
eth0 data: 74 frags:
eth0 data: 66 frags: 4096 4096 4096 4096 1508 4
eth0 data: 66 frags: 2584 4096 2268
eth0 data: 66 frags: 1828 4096 3024
eth0 data: 66 frags: 1072 4096 4096 4096 4096 4096 4096 1192 4
eth0 data: 66 frags: 2900 4096 4096 4096 2704 4
eth0 data: 66 frags: 1388 4096 3464
eth0 data: 66 frags: 632 4096 4096 4096 4096 876 4
9000 MTU+sendfile:
eth0 data: 74 frags:
eth0 data: 66 frags: 4096 4096 4092 4
eth0 data: 66 frags: 4096 4096 4096 4096 1508 4
eth0 data: 66 frags: 2584 4096 4092 4
eth0 data: 66 frags: 4096 4096 4096 4096 1508 4
eth0 data: 66 frags: 2584 4096 4096 4096 3020 4
eth0 data: 66 frags: 1072 4096 4096 4096 4096 436 4
eth0 data: 66 frags: 3656 4096 4096 4096 1948 4
next prev parent reply other threads:[~2005-05-06 7:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 6:07 [PATCH] TSO Reloaded David S. Miller
2005-05-05 22:35 ` David S. Miller
2005-05-05 22:56 ` Jon Mason
[not found] ` <20050505154955.0dcb4b38.davem@davemloft.net>
2005-05-06 3:53 ` Jon Mason
2005-05-05 23:11 ` Anton Blanchard
2005-05-05 23:14 ` David S. Miller
2005-05-06 1:03 ` Anton Blanchard
2005-05-05 23:18 ` Nivedita Singhvi
2005-05-05 23:24 ` Stephen Hemminger
2005-05-05 23:16 ` David S. Miller
2005-05-06 3:20 ` Leonid Grossman
2005-05-06 3:30 ` David S. Miller
2005-05-06 14:09 ` Leonid Grossman
2005-05-06 4:36 ` Anton Blanchard
2005-05-06 5:45 ` Anton Blanchard
2005-05-06 6:13 ` David S. Miller
2005-05-06 7:10 ` Anton Blanchard [this message]
2005-05-06 8:19 ` David S. Miller
2005-05-06 8:36 ` Anton Blanchard
2005-05-18 2:26 ` John Heffner
2005-05-18 2:28 ` David S. Miller
2005-05-18 2:51 ` John Heffner
2005-05-18 3:00 ` David S. Miller
2005-05-18 3:47 ` John Heffner
2005-05-18 5:59 ` David S. Miller
2005-05-18 13:48 ` John Heffner
[not found] <20050506123411.7073cf15.davem@davemloft.net>
2005-05-07 4:48 ` Leonid Grossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506071005.GG8255@krispykreme \
--to=anton@samba.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).