netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: mchan@broadcom.com
Cc: mperaya@alcazaba.unex.es, netdev@oss.sgi.com
Subject: Re: tg3 support broken on PPC, a workaround
Date: Tue, 10 May 2005 12:12:14 -0700 (PDT)	[thread overview]
Message-ID: <20050510.121214.39158393.davem@davemloft.net> (raw)
In-Reply-To: <1115743966.8570.26.camel@rh4>

From: "Michael Chan" <mchan@broadcom.com>
Subject: Re: tg3 support broken on PPC, a workaround
Date: Tue, 10 May 2005 09:52:46 -0700

> In the new code, the DMA write bursts will disconnect at multiples of
> cache lines instead of 1 cache line. And DMA read bursts will not
> disconnect at cache line boundaries.

We really should be disconnecting at single cacheline boundaries
on RISC systems.  The PCI controllers on RISC machines are
going to disconnect the tg3 when it crosses a cache line
boundary, so all these setting do is waste PCI bandwidth.

>From the sparc64 PCI controller programmer's manual:

"When a DMA burst transfer attempts to go past a cache line (64B)
 boundary, U2P generates a disconnect.  This should cause the
 master device to attempt the transaction again beginning at the
 address of the next untransferred data."

Most other RISC systems have PCI controllers which
behave similarly if not identically, although there
are probably some exceptions.

Anyways, it is clear this code needs to change. :-)

  reply	other threads:[~2005-05-10 19:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10  9:33 tg3 support broken on PPC, a workaround Manuel Perez Ayala
2005-05-10 16:52 ` Michael Chan
2005-05-10 19:12   ` David S. Miller [this message]
2005-05-10 19:43     ` Michael Chan
2005-05-10 21:15       ` David S. Miller
2005-05-10 20:26     ` David S. Miller
2005-05-10 20:14       ` Michael Chan
2005-05-10 21:23         ` David S. Miller
2005-05-10 20:49           ` Michael Chan
2005-05-10 20:32       ` David S. Miller
2005-05-10 22:13     ` Rick Jones
2005-05-10 23:21       ` Grant Grundler
2005-05-10 23:36         ` David S. Miller
2005-05-11  6:04   ` Manuel Perez Ayala
2005-05-11 15:24     ` Michael Chan
2005-05-12  9:28       ` Manuel Perez Ayala
2005-05-12 16:33         ` Rick Jones
2005-05-12 18:06           ` Manuel Perez Ayala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050510.121214.39158393.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=mperaya@alcazaba.unex.es \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).