From: Michael Ellerman <michael@ellerman.id.au>
To: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up
Date: Thu, 12 May 2005 17:47:27 +1000 [thread overview]
Message-ID: <200505121747.27752.michael@ellerman.id.au> (raw)
Hi Andrew, Jeff,
The iseries_veth driver has a logic bug which means it will erroneously
send packets to LPARs for which we don't have a connection.
This usually isn't a big problem because the Hypervisor call fails
gracefully and we return, but if packets are TX'ed during the negotiation
of the connection bad things might happen.
Regardless, the right thing is to bail early if we know there's no
connection.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
--
iseries_veth.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: veth-fixes/drivers/net/iseries_veth.c
===================================================================
--- veth-fixes.orig/drivers/net/iseries_veth.c
+++ veth-fixes/drivers/net/iseries_veth.c
@@ -924,7 +924,7 @@ static int veth_transmit_to_one(struct s
spin_lock_irqsave(&cnx->lock, flags);
- if (! cnx->state & VETH_STATE_READY)
+ if (! (cnx->state & VETH_STATE_READY))
goto drop;
if ((skb->len - 14) > VETH_MAX_MTU)
next reply other threads:[~2005-05-12 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 7:47 Michael Ellerman [this message]
2005-05-15 22:08 ` [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505121747.27752.michael@ellerman.id.au \
--to=michael@ellerman.id.au \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).