From: Stephen Hemminger <shemminger@osdl.org>
To: Jamal Hadi Salim <hadi@znyx.com>, Patrick McHardy <kaber@trash.net>
Cc: netdev@oss.sgi.com, lartc <lartc@mailman.ds9a.nl>
Subject: Qdisc requeue should be void?
Date: Fri, 13 May 2005 10:57:54 -0700 [thread overview]
Message-ID: <20050513105754.2e7cc243@dxpl.pdx.osdl.net> (raw)
There is an design problem with the qdisc interface that causes qlen related bugs
in netem, tbf, and other qdisc's that peek at the top of the queue. The problem is
that requeue needs to be called from the dequeue function but requeue can fail.
If requeue fails, then the calling qdisc can not properly handle the error. If it
returns NULL, then the parent's expectation about qlen gets messed up.
Example:
prio (qlen = 1)
skb = netem dequeue
skb = htb dequeue
... decides not to send this skb now
htp requeue(skb) fails
?? what now
--netem.qlen // := 0
return NULL
skb is NULL
at this point prio qlen is 1 but underlying queue's are empty.
My proposal is to require requeue to always succeed and change it to be
void instead of returning int.
next reply other threads:[~2005-05-13 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 17:57 Stephen Hemminger [this message]
2005-05-17 20:47 ` Qdisc requeue should be void? Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050513105754.2e7cc243@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=hadi@znyx.com \
--cc=kaber@trash.net \
--cc=lartc@mailman.ds9a.nl \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).